-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ownership of BluetoothAdapter in BluetoothDeviceChooserController
BluetoothAdapter is a reference counted object and so BluetoothDeviceChooserController should own it using a scoped_refptr. Fixing this requires also fixing BluetoothAdapterFactoryWrapper's AcquireAdapterCallback to take a scoped_refptr rather than a raw pointer. A test for proper ownership has been added. (cherry picked from commit a255d1b) (cherry picked from commit ee96769) Bug: 1024121 Change-Id: I6342322e059f9cbff2a0d5f073f6bccfb0ca7c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914536 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#715206} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916960 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3967@{#3} Cr-Original-Branched-From: 4042bae-refs/heads/master@{#715079} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917282 Cr-Commit-Position: refs/branch-heads/3966@{#3} Cr-Branched-From: 71c035f-refs/heads/master@{#714552}
- Loading branch information
Showing
7 changed files
with
33 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters