Removed typos. #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
aarongable
pushed a commit
that referenced
this pull request
Jul 23, 2018
This reverts commit c2bc780. Reason for revert: Lots of breakages on Debug builders # Fatal error in ../../v8/src/api.cc, line 5960 # Check failed: expected == value ((nil) vs. 0x11b5bca8d0e8). # # # #FailureMessage Object: 0x7fff42dfe070#0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace() #1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace() #2 0x7fd6e76e76f7 gin::(anonymous namespace)::PrintStackTrace() #3 0x7fd6dad0b918 V8_Fatal() #4 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase() #5 0x7fd6e2a5a310 blink::ToBlinkString<>() #6 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>() #7 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString() #8 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod() #9 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback() #10 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call() #11 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #12 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall() #13 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall() #14 0x7fd6fac565f5 <unknown> Received signal 4 ILL_ILLOPN 7fd6dad10b62 #0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace() #1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace() #2 0x7fd6fdc37054 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fd6df1c60c0 <unknown> #4 0x7fd6dad10b62 v8::base::OS::Abort() #5 0x7fd6dad0b925 V8_Fatal() #6 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase() #7 0x7fd6e2a5a310 blink::ToBlinkString<>() #8 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>() #9 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString() #10 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod() #11 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback() #12 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call() #13 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #14 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall() #15 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall() #16 0x7fd6fac565f5 <unknown> Original change's description: > Update V8 to version 7.0.1. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d7b61abe..8766d3dd > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Id0a466229f294e8afa3e887d9814926b592815b7 > Reviewed-on: https://chromium-review.googlesource.com/1145698 > Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#576998} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com NOTRY=TRUE Change-Id: I86ecc3dba8ab82f9e2968b3905033539f9363098 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1146420 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577105}
aikuimail
pushed a commit
to aikuimail/chromium
that referenced
this pull request
Jul 24, 2018
… base::RunLoop." This reverts commit 54fcb75. Reason for revert: landed too early and causing flakes Original change's description: > Reland chromium#3: Switch WindowedNotificationObserver to use base::RunLoop. > > Now it will quit the message loop immediately after receiving the > notification. Also it does not allow nested tasks anymore. > > Bug: 668707 > Change-Id: I8d8a0ffb073236c3bbd00877bd48cc496b1c5036 > Reviewed-on: https://chromium-review.googlesource.com/982612 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#576110} TBR=gab@chromium.org,jam@chromium.org,ahest@yandex-team.ru Change-Id: Ibc82b94b56e77bb9914c74517dd9f755527544f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 668707 Reviewed-on: https://chromium-review.googlesource.com/1143740 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576519}
aikuimail
pushed a commit
to aikuimail/chromium
that referenced
this pull request
Jul 24, 2018
This reverts commit 6f3f1a9. Reason for revert: Seems to cause the following tests to fail due to a memory leak: FileManagerFileTasksCrostiniTest.BasicFiles FileManagerFileTasksCrostiniTest.MultipleTypes FileManagerFileTasksCrostiniTest.MultipleMatches See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28317 Sample output snippet: Indirect leak of 384 byte(s) in 1 object(s) allocated from: #0 0xbe89c2 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 chromium#1 0xec8724f in LoadIcons chrome/browser/chromeos/crostini/crostini_util.cc:141:5 chromium#2 0xec8724f in LoadIcons(Profile*, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, int, ui::ScaleFactor, base::TimeDelta, base::OnceCallback<void (std::__1::vector<gfx::ImageSkia, std::__1::allocator<gfx::ImageSkia> > const&)>) chrome/browser/chromeos/crostini/crostini_util.cc:340 chromium#3 0xed5ecd9 in file_manager::file_tasks::FindCrostiniTasks(Profile*, std::__1::vector<extensions::EntryInfo, std::__1::allocator<extensions::EntryInfo> > const&, std::__1::vector<file_manager::file_tasks::FullTaskDescriptor, std::__1::allocator<file_manager::file_tasks::FullTaskDescriptor> >*, base::OnceCallback<void ()>) chrome/browser/chromeos/file_manager/crostini_file_tasks.cc:123:3 chromium#4 0xed74e13 in file_manager::file_tasks::FindExtensionAndAppTasks(Profile*, std::__1::vector<extensions::EntryInfo, std::__1::allocator<extensions::EntryInfo> > const&, std::__1::vector<GURL, std::__1::allocator<GURL> > const&, base::RepeatingCallback<void (std::__1::unique_ptr<std::__1::vector<file_manager::file_tasks::FullTaskDescriptor, std::__1::allocator<file_manager::file_tasks::FullTaskDescriptor> >, std::__1::default_delete<std::__1::vector<file_manager::file_tasks::FullTaskDescriptor, std::__1::allocator<file_manager::file_tasks::FullTaskDescriptor> > > >)> const&, std::__1::unique_ptr<std::__1::vector<file_manager::file_tasks::FullTaskDescriptor, std::__1::allocator<file_manager::file_tasks::FullTaskDescriptor> >, std::__1::default_delete<std::__1::vector<file_manager::file_tasks::FullTaskDescriptor, std::__1::allocator<file_manager::file_tasks::FullTaskDescriptor> > > >) chrome/browser/chromeos/file_manager/file_tasks.cc:624:3 Original change's description: > Show icons for Crostini Apps in the File Manager > > This patch adds support for app icons when used as file handlers in the > file manager. As there is no place to store the CrostiniAppIcon > objects, a IconLoadWaiter is added which manually manages it's lifetime > and deletes itself after an icon is loaded (or fails to load). > > BUG=822513 > > Change-Id: Ia31b32806e399df8902ffbf5c953e39dbc414774 > Reviewed-on: https://chromium-review.googlesource.com/1127204 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576385} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org Change-Id: I03ede5af292b3a33fb86ad408f6c4596c876e3ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822513 Reviewed-on: https://chromium-review.googlesource.com/1144020 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576554}
aarongable
pushed a commit
that referenced
this pull request
Jul 25, 2018
…askQueueController"" This reverts commit fa8e920. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6992 [ RUN ] MainThreadSchedulerImplTest.Tracing Received signal 11 <unknown> 000000000000 #0 0x7fb8aa445edd base::debug::StackTrace::StackTrace() #1 0x7fb8aa15949c base::debug::StackTrace::StackTrace() #2 0x7fb8aa445968 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fb89dd8a330 <unknown> #4 0x7fb8aa3eb77e logging::CheckEQImpl<>() #5 0x7fb8aa3e531c base::trace_event::TracedValue::EndDictionary() #6 0x7fb8aaf41afe blink::scheduler::MainThreadSchedulerImpl::AsValueLocked() #7 0x7fb8aaf40792 blink::scheduler::MainThreadSchedulerImpl::AsValue() #8 0x00000181a3aa blink::scheduler::main_thread_scheduler_impl_unittest::MainThreadSchedulerImplTest_Tracing_Test::TestBody() #9 0x000000c4452e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #10 0x000000c38192 testing::internal::HandleExceptionsInMethodIfSupported<>() #11 0x000000c1bd06 testing::Test::Run() #12 0x000000c1c6f0 testing::TestInfo::Run() #13 0x000000c1d19f testing::TestCase::Run() #14 0x000000c2f348 testing::internal::UnitTestImpl::RunAllTests() #15 0x000000c445be testing::internal::HandleSehExceptionsInMethodIfSupported<>() #16 0x000000c39942 testing::internal::HandleExceptionsInMethodIfSupported<>() #17 0x000000c2efa7 testing::UnitTest::Run() #18 0x000001a62ac1 RUN_ALL_TESTS() #19 0x000001a5f48b base::TestSuite::Run() #20 0x000000bd1d45 (anonymous namespace)::runTestSuite() #21 0x000000a3e560 _ZN4base8internal13FunctorTraitsIPFvPbEvE6InvokeIRKS4_JRKS2_EEEvOT_DpOT0_ #22 0x000000a3e51d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPbEJS4_EEEvOT_DpOT0_ #23 0x000000bd1f75 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #24 0x000000bd1ec9 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunOnceEPNS0_13BindStateBaseE #25 0x000001a708fe _ZNO4base12OnceCallbackIFivEE3RunEv #26 0x000001a697d0 base::(anonymous namespace)::LaunchUnitTestsInternal() #27 0x000001a69645 base::LaunchUnitTests() #28 0x000000bd1cd6 main #29 0x7fb89d4c3f45 __libc_start_main #30 0x000000552d1a _start r8: 0000000000000001 r9: 00007fff6f9d4b30 r10: 0000000000000000 r11: 0000000000000000 r12: 0000000000552cf0 r13: 00007fff6f9d6af0 r14: 0000000000000000 r15: 0000000000000000 di: 00007fb8aa50a878 si: 200031ca83cdc758 bp: 00007fff6f9d4990 bx: 0000000000000000 dx: 00007fff6f9d4ae8 ax: 00007fb8aa50a800 cx: 0000000000000000 sp: 00007fff6f9d4960 ip: 00007fb8aa3eb77e efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Original change's description: > Reland "[scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController" > > This is a reland of e2d8996 > > Original change's description: > > [scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController > > > > This CL moves all task queue management and creation to > > FrameTaskQueueController and adds the appropriate interface for > > accessing queues in FrameTaskQueueController. TaskType to QueueTraits > > management is handled by FrameSchedulerImpl since it embeds policy, and > > FrameTaskQueueController exposes an interface to get non-loading task > > queues by QueueTraits, as well as accessing loading and loading > > control task queues. > > > > Bug: 859963 > > Change-Id: I7db5aaaa148d0dc4f3f70e517e088a205e502db8 > > Reviewed-on: https://chromium-review.googlesource.com/1142390 > > Commit-Queue: Scott Haseley <shaseley@google.com> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#576619} > > Bug: 859963 > Change-Id: Id2c9179b580759b815602d61b98c99d1f3f5253d > Reviewed-on: https://chromium-review.googlesource.com/1144608 > Commit-Queue: Scott Haseley <shaseley@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578008} TBR=altimin@chromium.org,panicker@chromium.org,shaseley@google.com Change-Id: Ia71d2641655c8100b82a8ce7e4a11009d19b5e9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859963 Reviewed-on: https://chromium-review.googlesource.com/1150585 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578067}
aarongable
pushed a commit
that referenced
this pull request
Jul 27, 2018
This reverts commit df6e77c. Reason for revert: Reverting as suspect of failing case_media_unittests . https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/16824 : [ RUN ] CastAudioManagerTest.MakeAudioOutputStreamProxy ../../chromecast/media/audio/cast_audio_manager_unittest.cc:106: Failure Actual function call count doesn't match EXPECT_CALL(*backend, Initialize())... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: #0 0x00000054cffc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000054c9d9 testing::internal::AssertHelper::operator=() #2 0x00000053ddd3 testing::internal::GoogleTestFailureReporter::ReportFailure() #3 0x0000005405b6 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() #4 0x0000003e7142 chromecast::media::MockCmaBackend::~MockCmaBackend() #5 0x0000003a7340 testing::StrictMock<>::~StrictMock() #6 0x0000003a44b5 chromecast::media::(anonymous namespace)::CastAudioManagerTest_MakeAudioOutputStreamProxy_Test::TestBody() ../../chromecast/media/audio/cast_audio_manager_unittest.cc:105: Failure Actual function call count doesn't match EXPECT_CALL(*backend, CreateAudioDecoder())... Expected: to be called once Actual: never called - unsatisfied and active Original change's description: > Fetch and apply Multiroom info in CAOS > > CastAudioOutputStream can now use internal backends with multizone. In > order for multizone to work, we first need to retrieve the multiroom > info and pass it to the backend. > > BUG=b:111694183 > TEST=Build, cast_media_unittests > > Change-Id: I128a6b0cc1a389d01102007244fdb5594dd4c637 > Reviewed-on: https://chromium-review.googlesource.com/1145892 > Reviewed-by: Kenneth MacKay <kmackay@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578670} TBR=sky@chromium.org,gab@chromium.org,halliwell@chromium.org,jameswest@chromium.org,kmackay@chromium.org,awolter@chromium.org Change-Id: I519349d1cd87709c2a1bd39299420b5a7df7bcee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:111694183 Reviewed-on: https://chromium-review.googlesource.com/1153309 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578685}
aarongable
pushed a commit
that referenced
this pull request
Jul 27, 2018
This reverts commit df84748. Reason for revert: To fix unit_tests (I have to revert this before the earlier patch). Likely suspect for BrowserThemePackTest.HiDpiThemeTest failing on bots. For example, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11230 : [ RUN ] BrowserThemePackTest.HiDpiThemeTest ../../chrome/browser/themes/browser_theme_pack_unittest.cc:204: Failure Expected equality of these values: "" error Which is: "File doesn't exist." Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9b98 BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() ../../chrome/browser/themes/browser_theme_pack_unittest.cc:205: Failure Value of: valid_value.get() Actual: false Expected: true Stack trace: #0 0x0000026103ac testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x00000260fd89 testing::internal::AssertHelper::operator=() #2 0x000000fc9e0b BrowserThemePackTest::BuildFromUnpackedExtension() #3 0x000000fd22cc BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() Received signal 11 SEGV_MAPERR 000000000028 #0 0x000004d00e1c base::debug::StackTrace::StackTrace() #1 0x000004d00981 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f26bba79330 <unknown> #3 0x0000050f3e24 BrowserThemePack::WriteToDisk() #4 0x000000fd22db BrowserThemePackTest_HiDpiThemeTest_Test::TestBody() #5 0x0000026161b2 testing::Test::Run() #6 0x000002616d30 testing::TestInfo::Run() #7 0x000002617247 testing::TestCase::Run() #8 0x000002622747 testing::internal::UnitTestImpl::RunAllTests() #9 0x0000026222bd testing::UnitTest::Run() #10 0x0000045565d1 base::TestSuite::Run() #11 0x000004557fca base::(anonymous namespace)::LaunchUnitTestsInternal() #12 0x000004557e7a base::LaunchUnitTests() #13 0x00000454e155 main #14 0x7f26b86c9f45 __libc_start_main #15 0x0000006fa82a _start r8: 0000000000000000 r9: 54656d6568546970 r10: 747365545f747365 r11: 0000000000000000 r12: 000024a8af0c0d20 r13: 00007fff447924e8 r14: 00007fff44792560 r15: 0000000000000000 di: 0000000000000000 si: 00007fff44792560 bp: 00007fff44792520 bx: 00007fff44792578 dx: 00000000000005e7 ax: 0000000000001fdd cx: 0000000000000023 sp: 00007fff44792490 ip: 00000000050f3e24 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000028 [end of stack trace] Original change's description: > Compute colors for the frame and tabs from provided images. > > If theme authors explicitly provide values here, we'll use them; but if they > don't, but do provide images, set the colors to be the dominant colors of the > images, using an existing K-means algorithm (similar to what we use for > computing representative favicon colors etc.). > > This allows us to rely on those colors later when deciding what color to make > tab text, the new tab button, and similar tabstrip/window frame items. > > This also does a bit of cleanup to the theme pack code, e.g. moving a map used > in only one function into that function to make its provenance clearer. I can > try to split this apart into more CLs if desired. > > Bug: 862664 > Change-Id: I8c3f15893ad491a6fee8aa5f76ae162cecb2c6fd > Reviewed-on: https://chromium-review.googlesource.com/1152517 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578823} TBR=pkasting@chromium.org,asvitkine@chromium.org,estade@chromium.org Change-Id: I6a5a7f2916136ccf93101f36c34a17a4e5ef5d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862664 Reviewed-on: https://chromium-review.googlesource.com/1153988 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578856}
aarongable
pushed a commit
that referenced
this pull request
Jul 31, 2018
This ensures that deserialize -> serialize produces the same result as deserialize -> serialize -> deserialize -> serialize for a particular reproducer discovered by clusterfuzz. It was previously possible for the first serialization to produce a different result than the second one in the following way: - the first deserialize would set the matrix type initially to unknown (in FixupMatrixPostSerialization) but then set it to the correct matrix type as a side effect of creating a transfer cache entry (see the following stack trace): #0 0x00000000006c9f70 in SkMatrix::getType() const () at ../../third_party/skia/include/core/SkMatrix.h:140 #1 0x00000000006d3f3d in SkMatrix::isIdentity() const () at ../../third_party/skia/include/core/SkMatrix.h:155 #2 0x00000000006d1031 in SkMatrix::invert(SkMatrix*) const () at ../../third_party/skia/include/core/SkMatrix.h:1152 #3 0x0000000000a7e330 in SkGradientShader::MakeSweep(float, float, SkColor4f const*, sk_sp<SkColorSpace>, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:886 #4 0x0000000000a7e1c0 in SkGradientShader::MakeSweep(float, float, unsigned int const*, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:863 #5 0x0000000000dc2e0d in CreateSkShader() () at ../../cc/paint/paint_shader.cc:397 #6 0x0000000000daf94d in Read() () at ../../cc/paint/paint_op_reader.cc:522 - the first serialize would write out the correct matrix type verbatim from the data structure - the second deserialize would set the matrix type to unknown but would not end up setting it to the correct matrix type because a transfer cache entry exists so we follow this code path instead: https://cs.chromium.org/chromium/src/cc/paint/paint_op_reader.cc?l=519 - the second serialize would again write the matrix type verbatim from the data structure, but this time it would be unknown. This change fixes the problem by always writing unknown. Bug: 868966 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idfb1dcf82e652b696dde5427d9890b0ff6d9a268 Reviewed-on: https://chromium-review.googlesource.com/1156127 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579453}
aarongable
pushed a commit
that referenced
this pull request
Aug 14, 2018
…ts)" This reverts commit 562c52f. Reason for revert: cc_unittests failing on Linux TSan: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/24797 [ RUN ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy [22487:22487:0814/143420.957209:26522082454:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000 [22487:22487:0814/143420.957442:26522082676:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200 [22487:22487:0814/143421.140401:26522265659:ERROR:pixel_test_utils.cc(79)] Pixels do not match! [22487:22487:0814/143421.140586:26522265816:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACHUlEQVR4nO3VMRHAMBADwXf4ozUBh0DmWqfYRaDmRmvvOQN8em4PgD8TCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQFgz+9weAX/lQSAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAILygpAZjjfRdXgAAAABJRU5ErkJggg== [22487:22487:0814/143421.140737:26522266017:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAIAAAAiOjnJAAACNklEQVR4nO3dsQ0DMQwEQb3hWP3XqQrcgEMvnm/MVMBgwfSutc6CX3vdfQD/SVgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRF4n33Ad+ds+8+4TH2nriR62OREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGRuM7Eec6hq6EzzVyj9bFICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBIDF1Y5el8LBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBIfCVIMShDYZKEAAAAASUVORK5CYII= ../../cc/test/layer_tree_pixel_test.cc:129: Failure Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_) Actual: false Expected: true Stack trace: #0 0x000001ceb5ff (/b/s/w/ir/out/Release/cc_unittests+0x1ceb5fe) #1 0x0000017ae1e9 (/b/s/w/ir/out/Release/cc_unittests+0x17ae1e8) #2 0x0000017bda1f (/b/s/w/ir/out/Release/cc_unittests+0x17bda1e) #3 0x0000017bd178 (/b/s/w/ir/out/Release/cc_unittests+0x17bd177) #4 0x000001a362be (/b/s/w/ir/out/Release/cc_unittests+0x1a362bd) #5 0x000001a3b5ba (/b/s/w/ir/out/Release/cc_unittests+0x1a3b5b9) [ FAILED ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy (4296 ms) Original change's description: > Roll src/third_party/skia 32c7d4dfcdca..d19fed1e291d (2 commits) > > https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..d19fed1e291d > > > git log 32c7d4dfcdca..d19fed1e291d --date=short --no-merges --format='%ad %ae %s' > 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations > 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting. > > > Created with: > gclient setdep -r src/third_party/skia@d19fed1e291d > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=kjlubick@chromium.org > > Change-Id: Ib608389718b76c94782e3415bcc82dc607902e82 > Reviewed-on: https://chromium-review.googlesource.com/1174793 > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#583019} TBR=kjlubick@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I0e6bc9c3c8c052a0ae17eb292cad8bb5e579faf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1174639 Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#583063}
aarongable
pushed a commit
that referenced
this pull request
Aug 15, 2018
This reverts commit b58ccf6. Reason for revert: Possibly introduced a use-after-free bug. This is a speculative fix for a use-after-free bug in two ash_unittests: 1. OverflowButtonInkDropTest.MouseContextMenu 2. OverflowButtonActiveInkDropTest.MouseContextMenu [ RUN ] OverflowButtonInkDropTest.MouseContextMenu ================================================================= ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 READ of size 8 at 0x613000031f68 thread T0 #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 #3 0x8c82105 in HasObserver base/observer_list.h:267 #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 #24 0x72b9892 in Run base/callback.h:99:12 #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #27 0x178df94 in main ash/test/ash_unittests.cc:37:10 #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) freed by thread T0 here: #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 #13 0x72b9892 in Run base/callback.h:99:12 #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #16 0x178df94 in main ash/test/ash_unittests.cc:37:10 #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 previously allocated by thread T0 here: #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 #25 0x72b9892 in Run base/callback.h:99:12 #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 #28 0x178df94 in main ash/test/ash_unittests.cc:37:10 #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin Shadow bytes around the buggy address: 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==28149==ABORTING Original change's description: > cros: Enable touchable app context menus by default. > > This will enable: > - New context menu UI for: > - Application icons > - Shelf context menus > - Desktop context menus > > Note: > - Removed tests whose functionality were already being tested. > - MouseContextMenu already tests whether the ink drop is being > shown, so there is no need for > ShelfButtonShowsInkDropHighlightOnMenuShow. > > Bug: 871843 > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > Reviewed-on: https://chromium-review.googlesource.com/1170985 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582978} TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174641 Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#583088}
aarongable
pushed a commit
that referenced
this pull request
Aug 15, 2018
This reverts commit 32cd8fc. Reason for revert: Reverting the revert because this change was proven to not have caused the issue. Original change's description: > Revert "cros: Enable touchable app context menus by default." > > This reverts commit b58ccf6. > > Reason for revert: Possibly introduced a use-after-free bug. > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > 1. OverflowButtonInkDropTest.MouseContextMenu > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > ================================================================= > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > READ of size 8 at 0x613000031f68 thread T0 > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > #3 0x8c82105 in HasObserver base/observer_list.h:267 > #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #24 0x72b9892 in Run base/callback.h:99:12 > #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > freed by thread T0 here: > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #13 0x72b9892 in Run base/callback.h:99:12 > #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > previously allocated by thread T0 here: > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #25 0x72b9892 in Run base/callback.h:99:12 > #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > Shadow bytes around the buggy address: > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > Shadow byte legend (one shadow byte represents 8 application bytes): > Addressable: 00 > Partially addressable: 01 02 03 04 05 06 07 > Heap left redzone: fa > Freed heap region: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user: f7 > Container overflow: fc > Array cookie: ac > Intra object redzone: bb > ASan internal: fe > Left alloca redzone: ca > Right alloca redzone: cb > Shadow gap: cc > ==28149==ABORTING > > Original change's description: > > cros: Enable touchable app context menus by default. > > > > This will enable: > > - New context menu UI for: > > - Application icons > > - Shelf context menus > > - Desktop context menus > > > > Note: > > - Removed tests whose functionality were already being tested. > > - MouseContextMenu already tests whether the ink drop is being > > shown, so there is no need for > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > Bug: 871843 > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582978} > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174641 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Chris Mumford <cmumford@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583088} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174777 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583310}
aarongable
pushed a commit
that referenced
this pull request
Aug 16, 2018
This reverts commit e2c5501. Reason for revert: Causes ash_unittests regressions. This is NOT a speculative revert, as I've bisected to this commit and reproduced it locally. Please do not reland as is. Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28629 Original change's description: > Reland "cros: Enable touchable app context menus by default." > > This reverts commit 32cd8fc. > > Reason for revert: Reverting the revert because this change was proven to not have caused the issue. > > Original change's description: > > Revert "cros: Enable touchable app context menus by default." > > > > This reverts commit b58ccf6. > > > > Reason for revert: Possibly introduced a use-after-free bug. > > > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > > > 1. OverflowButtonInkDropTest.MouseContextMenu > > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > > ================================================================= > > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > > READ of size 8 at 0x613000031f68 thread T0 > > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > > #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > > #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > > #3 0x8c82105 in HasObserver base/observer_list.h:267 > > #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > > #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > > #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > > #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > > #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > > #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > > #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > > #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > > #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > > #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > > #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > > #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > #24 0x72b9892 in Run base/callback.h:99:12 > > #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > #27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > > freed by thread T0 here: > > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > > #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > > #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > > #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > > #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > > #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > > #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > > #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > #13 0x72b9892 in Run base/callback.h:99:12 > > #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > #16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > previously allocated by thread T0 here: > > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > > #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > > #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > > #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > > #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > > #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > > #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > > #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > > #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > > #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > > #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > > #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > > #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > > #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > > #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > > #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > > #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > > #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > > #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > > #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > > #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > > #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > > #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > > #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > > #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > > #25 0x72b9892 in Run base/callback.h:99:12 > > #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > > #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > > #28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > > #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > > Shadow bytes around the buggy address: > > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > > Shadow byte legend (one shadow byte represents 8 application bytes): > > Addressable: 00 > > Partially addressable: 01 02 03 04 05 06 07 > > Heap left redzone: fa > > Freed heap region: fd > > Stack left redzone: f1 > > Stack mid redzone: f2 > > Stack right redzone: f3 > > Stack after return: f5 > > Stack use after scope: f8 > > Global redzone: f9 > > Global init order: f6 > > Poisoned by user: f7 > > Container overflow: fc > > Array cookie: ac > > Intra object redzone: bb > > ASan internal: fe > > Left alloca redzone: ca > > Right alloca redzone: cb > > Shadow gap: cc > > ==28149==ABORTING > > > > Original change's description: > > > cros: Enable touchable app context menus by default. > > > > > > This will enable: > > > - New context menu UI for: > > > - Application icons > > > - Shelf context menus > > > - Desktop context menus > > > > > > Note: > > > - Removed tests whose functionality were already being tested. > > > - MouseContextMenu already tests whether the ink drop is being > > > shown, so there is no need for > > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > > > Bug: 871843 > > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#582978} > > > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 871843 > > Reviewed-on: https://chromium-review.googlesource.com/1174641 > > Reviewed-by: Chris Mumford <cmumford@chromium.org> > > Commit-Queue: Chris Mumford <cmumford@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#583088} > > TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org > > Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174777 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583310} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I8398745c9037fb5be605069646b3a655519d023e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1177482 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#583619}
aarongable
pushed a commit
that referenced
this pull request
Aug 22, 2018
This reverts commit ba40c8a. Reason for revert: Causing failure on Linux Tests (dbg) bot. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52253 Sample logs: [ RUN ] AXPlatformNodeAuraLinuxTest.TestAtkText ../../ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc:871: Failure Value of: ATK_IS_TEXT(root_atk_object) Actual: false Expected: true Stack trace: #0 0x000008299a59 StackTraceGetter::CurrentStackTrace() #1 0x0000082be414 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x0000082bd86e testing::internal::AssertHelper::operator=() #3 0x00000821fe0c ui::AXPlatformNodeAuraLinuxTest_TestAtkText_Test::TestBody() #4 0x0000082f91eb testing::internal::HandleSehExceptionsInMethodIfSupported<>() [ FAILED ] AXPlatformNodeAuraLinuxTest.TestAtkText (2 ms) Original change's description: > Expose the basic AtkText interface for text elements > > AtkText is the proper way to expose static text to accessibility agents. > This change adds initial support for the interface, but there is quite a > bit of work left to properly expose hypertext as well as implement the > rest of the required interface functionality. > > Bug: 866337 > Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18 > Reviewed-on: https://chromium-review.googlesource.com/1179752 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584989} TBR=dmazzoni@chromium.org,mrobinson@igalia.com Change-Id: Idb25bb0c8bd494b10f6eed2fd213552178a5f62b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866337 Reviewed-on: https://chromium-review.googlesource.com/1184924 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585013}
aarongable
pushed a commit
that referenced
this pull request
Aug 24, 2018
This reverts commit 42ad79b. Reason for revert: [chromium sheriff] A culprit of test failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28724 single_process_mash_browser_tests Run on OS: 'Ubuntu-14.04' Max shard duration: 0:03:53.214620 (shard #3) Min shard duration: 0:01:18.857780 (shard #0) failures: LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled LoginPromptBrowserTest.TestTwoAuths LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects LoginPromptBrowserTest.CancelRedundantAuths LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated LoginUtilsTest.MashLogin LoginPromptBrowserTest.IncorrectConfirmation LoginPromptBrowserTest.TestBasicAuth LoginPromptBrowserTest.TestCancelAuth_Manual LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials LoginPromptBrowserTest.SupplyRedundantAuths LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials LoginPromptBrowserTest.TestDigestAuth LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial LoginPromptBrowserTest.TestCancelAuth_OnBack LoginPromptBrowserTest.TestCancelAuth_OnForward LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources LoginPromptBrowserTest.TestCancelAuth_OnNavigation LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests Original change's description: > Add tests for single process mash > > Moves plain Mash tests to FYI waterfall, while retaining a login test on the > main waterfall as a sanity check. > > Bug: 874090 > Change-Id: I86c60344610c2a4f99b35f9116c5366771a16c64 > Reviewed-on: https://chromium-review.googlesource.com/1175222 > Commit-Queue: Ryan Cui <rcui@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585665} TBR=jamescook@chromium.org,sky@chromium.org,rcui@chromium.org Change-Id: Ib9b9258b47e766d43ac7f3dc6b3c65aacf1230f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874090 Reviewed-on: https://chromium-review.googlesource.com/1188165 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585781}
aarongable
pushed a commit
that referenced
this pull request
Aug 24, 2018
This reverts commit a6c0ed2. Reason for revert: reverting as fix for leak landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1188584 Original change's description: > Revert "Add tests for single process mash" > > This reverts commit 42ad79b. > > Reason for revert: [chromium sheriff] A culprit of test failures: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28724 > > single_process_mash_browser_tests Run on OS: 'Ubuntu-14.04' > Max shard duration: 0:03:53.214620 (shard #3) > Min shard duration: 0:01:18.857780 (shard #0) > failures: > LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled > LoginPromptBrowserTest.TestTwoAuths > LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects > LoginPromptBrowserTest.CancelRedundantAuths > LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect > LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated > LoginUtilsTest.MashLogin > LoginPromptBrowserTest.IncorrectConfirmation > LoginPromptBrowserTest.TestBasicAuth > LoginPromptBrowserTest.TestCancelAuth_Manual > LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials > LoginPromptBrowserTest.SupplyRedundantAuths > LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile > LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials > LoginPromptBrowserTest.TestDigestAuth > LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes > LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial > LoginPromptBrowserTest.TestCancelAuth_OnBack > LoginPromptBrowserTest.TestCancelAuth_OnForward > LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources > LoginPromptBrowserTest.TestCancelAuth_OnNavigation > LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests > > Original change's description: > > Add tests for single process mash > > > > Moves plain Mash tests to FYI waterfall, while retaining a login test on the > > main waterfall as a sanity check. > > > > Bug: 874090 > > Change-Id: I86c60344610c2a4f99b35f9116c5366771a16c64 > > Reviewed-on: https://chromium-review.googlesource.com/1175222 > > Commit-Queue: Ryan Cui <rcui@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: James Cook <jamescook@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#585665} > > TBR=jamescook@chromium.org,sky@chromium.org,rcui@chromium.org > > Change-Id: Ib9b9258b47e766d43ac7f3dc6b3c65aacf1230f4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 874090 > Reviewed-on: https://chromium-review.googlesource.com/1188165 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Commit-Queue: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585781} TBR=jamescook@chromium.org,sky@chromium.org,hayato@chromium.org,rcui@chromium.org Change-Id: I90f8aff5115e528b95ba80095389f61d07974962 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874090 Reviewed-on: https://chromium-review.googlesource.com/1188779 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585958}
aarongable
pushed a commit
that referenced
this pull request
Aug 28, 2018
This reverts commit 58a77e6. Reason for revert: Suspected for asan failures in exo_unittests starting https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28766 errors like ==346==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000049d48 at pc 0x000007341794 bp 0x7ffc028ccfb0 sp 0x7ffc028ccfa8 READ of size 8 at 0x616000049d48 thread T0 #0 0x7341793 in begin buildtools/third_party/libc++/trunk/include/vector:1471:30 #1 0x7341793 in base::ObserverList<views::ViewObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(views::ViewObserver const*) base/observer_list.h:272 #2 0x30ed227 in EnableWindowObservers ash/public/cpp/immersive/immersive_fullscreen_controller.cc:356:21 #3 0x30ed227 in ash::ImmersiveFullscreenController::Init(ash::ImmersiveFullscreenControllerDelegate*, views::Widget*, views::View*) ash/public/cpp/immersive/immersive_fullscreen_controller.cc:96 #4 0x7e8968 in exo::ClientControlledShellSurface::UpdateFrame() components/exo/client_controlled_shell_surface.cc:960:23 Original change's description: > Get Chrome App frame immersive mode closer to working in Mash > > Removes the ImmersiveFullscreenController from > ChromeNativeAppWindowViewsAuraAsh and relies on the default one provided > by Ash. Also: > > 1. Remove the WindowStateDelegate from ChromeNativeAppWindowViewsAuraAsh > - Listen for fullscreen changes in order to keep system fullscreen > state and AppWindow fullscreen state in sync. > - RestoreAlwaysOnTop should just work without the special delegate > implementation, as the taskbar handling in AppWindow is Windows- > specific. Tested by > WorkspaceLayoutManagerSoloTest.FullscreenSuspendsAlwaysOnTop > - Fold non-delegate functionality into main class > > 2. Remove the default Ash WindowStateDelegate (i.e. that created in > non_client_frame_view_ash.cc) which only overrode ToggleFullscreen. > The default implementation, ::wm::SetWindowFullscreen, works as > intended. > > 3. Add window properties to allow the client to enter/exit immersive mode, > get the position of the reveal view, and disable some ways of automatically > triggering immersive. > > TODO: propagate window properties across processes so that they work in OopAsh > TODO: In OopAsh, listen for window state changes into/out of fullscreen. (This > will replace the functionality that the frame gets from > WindowStateObserver::OnPostWindowStateTypeChange in classic Ash). > > Change-Id: I202942a146d96bee92e5997a922df1da361cb1a3 > Reviewed-on: https://chromium-review.googlesource.com/1176237 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586459} TBR=sky@chromium.org,estade@chromium.org Change-Id: I05c1d5daaae64a78492ea5eff17edb9c7b48c16c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1192366 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586552}
aarongable
pushed a commit
that referenced
this pull request
Sep 4, 2018
This reverts commit e6df634. Reason for revert: Suspect WebKit Linux Trusty MSAN failures: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9778 crash log for content_shell (pid 19555): STDOUT: <empty> STDERR: [1:16:0903/135605.516164:ERROR:adm_helpers.cc(73)] Failed to query stereo recording. STDERR: CONSOLE WARNING: line 371: The Web Audio autoplay policy will be re-enabled in Chrome 70 (October 2018). Please check that your website is compatible with it. https://goo.gl/7K7WLu STDERR: ==19555==WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x119c0a99 in network::P2PSocketUdp::HandleReadResult(int) ./../../services/network/p2p/socket_udp.cc:231:9 STDERR: #1 0x119bf30b in network::P2PSocketUdp::OnRecv(int) ./../../services/network/p2p/socket_udp.cc:202:3 STDERR: #2 0xc8cd202 in Run ./../../base/callback.h:99:12 STDERR: #3 0xc8cd202 in DoReadCallback ./../../net/socket/udp_socket_posix.cc:690:0 STDERR: #4 0xc8cd202 in net::UDPSocketPosix::DidCompleteRead() ./../../net/socket/udp_socket_posix.cc:711:0 STDERR: #5 0xc8cc98d in net::UDPSocketPosix::ReadWatcher::OnFileCanReadWithoutBlocking(int) ./../../net/socket/udp_socket_posix.cc:676:14 STDERR: #6 0xb3aa2ec in base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) ./../../base/message_loop/message_pump_libevent.cc:0:13 STDERR: #7 0xb3c2bd6 in event_process_active ./../../base/third_party/libevent/event.c:381:4 STDERR: #8 0xb3c2bd6 in event_base_loop ./../../base/third_party/libevent/event.c:521:0 STDERR: #9 0xb3aaf3e in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:214:5 STDERR: #10 0xb12a9ff in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 STDERR: #11 0x8655f3e in content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) ./../../content/browser/browser_process_sub_thread.cc:175:11 STDERR: #12 0xb26ea58 in base::Thread::ThreadMain() ./../../base/threading/thread.cc:357:3 STDERR: #13 0xb39a887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:76:13 STDERR: #14 0x7ffa170eb183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312:0 STDERR: #15 0x7ffa0fa3703c in clone /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 STDERR: STDERR: Uninitialized value was created by a heap allocation STDERR: #0 0x1ab9a79 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:46:35 STDERR: #1 0x119a51de in network::P2PSocket::Create(network::P2PSocket::Delegate*, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>, network::P2PSocketType, net::NetLog*, network::ProxyResolvingClientSocketFactory*, network::P2PMessageThrottler*) ./../../services/network/p2p/socket.cc:173:14 STDERR: #2 0x1198d68c in network::P2PSocketManager::CreateSocket(network::P2PSocketType, net::IPEndPoint const&, network::P2PPortRange const&, network::P2PHostAndIPEndPoint const&, mojo::InterfacePtr<network::mojom::P2PSocketClient>, mojo::InterfaceRequest<network::mojom::P2PSocket>) ./../../services/network/p2p/socket_manager.cc:294:7 STDERR: #3 0x1e6127b in network::mojom::P2PSocketManagerStubDispatch::Accept(network::mojom::P2PSocketManager*, mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.cc:1105:13 STDERR: #4 0x11991146 in network::mojom::P2PSocketManagerStub<mojo::RawPtrImplRefTraits<network::mojom::P2PSocketManager> >::Accept(mojo::Message*) ./gen/services/network/public/mojom/p2p.mojom.h:446:12 STDERR: #5 0xb407929 in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:423:32 STDERR: #6 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #7 0xb421df5 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:869:42 STDERR: #8 0xb41f60d in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:590:38 STDERR: #9 0xb4056da in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 STDERR: #10 0xb3fdbc2 in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:457:51 STDERR: #11 0xb400300 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:486:10 STDERR: #12 0xb3e106b in Run ./../../base/callback.h:129:12 STDERR: #13 0xb3e106b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:273:0 STDERR: #14 0xb3e1a6c in mojo::SimpleWatcher::Context::Notify(unsigned int, MojoHandleSignalsState, unsigned int) ./../../mojo/public/cpp/system/simple_watcher.cc:105:22 STDERR: #15 0xb3de578 in mojo::SimpleWatcher::Context::CallNotify(MojoTrapEvent const*) ./../../mojo/public/cpp/system/simple_watcher.cc:55:14 STDERR: #16 0x46bbfd7 in mojo::core::WatcherDispatcher::InvokeWatchCallback(unsigned long, unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watcher_dispatcher.cc:90:3 STDERR: #17 0x46b9935 in mojo::core::Watch::InvokeCallback(unsigned int, mojo::core::HandleSignalsState const&, unsigned int) ./../../mojo/core/watch.cc:78:13 STDERR: #18 0x46a4715 in mojo::core::RequestContext::~RequestContext() ./../../mojo/core/request_context.cc:72:20 STDERR: #19 0x466c618 in mojo::core::NodeChannel::OnChannelMessage(void const*, unsigned long, std::__1::vector<mojo::PlatformHandle, std::__1::allocator<mojo::PlatformHandle> >) ./../../mojo/core/node_channel.cc:695:1 STDERR: #20 0x461c6a4 in mojo::core::Channel::OnReadComplete(unsigned long, unsigned long*) ./../../mojo/core/channel.cc:714:18 STDERR: STDERR: SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/content_shell+0x119c0a99) STDERR: Exiting STDERR: [19588:19588:0903/135606.482234:WARNING:x11_util.cc(1391)] X error received: serial 170, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown) Original change's description: > Cleanup lifetime handling in P2P sockets. > > Several fixes for P2P sockets: > 1. P2PSocketTcpBase no longer posts tasks with base::Unretained(). > 2. Previously P2P sockets were destroyed only in response to Mojo > interfaces errors. They were not destroyed on other error. Fixed > it now. > 3. Simplified TCP server socket protocol. Now the accepted socket is > passed directly in IncomingTcpConnection. > 4. Updated unittests to verify that P2P sockets are destroyed in > response to errors. > 5. Other minor cleanups, particularly moved packet dump logic to > SocketManager and removed some unittests that are not relevant > after migration to mojo. > > Bug: 877515, 877514 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc > Reviewed-on: https://chromium-review.googlesource.com/1189083 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588430} TBR=nasko@chromium.org,jam@chromium.org,mmenke@chromium.org,sergeyu@chromium.org Change-Id: I33bfb1c8127a945df37fd8bf9efda681a739095e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877515, 877514 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1203492 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#588440}
aarongable
pushed a commit
that referenced
this pull request
Sep 12, 2018
content_browsertests failures:
RenderFrameHostImplBrowserTest.BeforeUnloadDialogSuppressedForDiscard
RenderFrameHostImplBrowserTest.PendingDialogMakesDiscardUnloadReturnFalse
==3811==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0xbc166ad in content::RenderFrameHostManager::OnBeforeUnloadACK(bool, base::TimeTicks const&) ./../../content/browser/frame_host/render_frame_host_manager.cc:215:7
#1 0xbbdbca8 in operator() ./../../content/browser/frame_host/render_frame_host_impl.cc:2079:54
#2 0xbbdbca8 in Invoke<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool> ./../../base/bind_internal.h:403:0
#3 0xbbdbca8 in MakeItSo<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool> ./../../base/bind_internal.h:616:0
#4 0xbbdbca8 in RunImpl<(lambda at ../../content/browser/frame_host/render_frame_host_impl.cc:2075:9), std::__1::tuple<base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool>, 0, 1, 2> ./../../base/bind_internal.h:689:0
#5 0xbbdbca8 in base::internal::Invoker<base::internal::BindState<content::RenderFrameHostImpl::ProcessBeforeUnloadACKFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&)::$_0, base::WeakPtr<content::RenderFrameHostImpl>, base::TimeTicks, bool>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:658:0
#6 0xbb36c00 in Run ./../../base/callback.h:99:12
#7 0xbb36c00 in content::RenderFrameHostImpl::ProcessBeforeUnloadACKFromFrame(bool, bool, content::RenderFrameHostImpl*, bool, base::TimeTicks const&, base::TimeTicks const&) ./../../content/browser/frame_host/render_frame_host_impl.cc:2087:0
Change-Id: I6ccc7f48accb2595665691ced6d415eb1777ba68
Reviewed-on: https://chromium-review.googlesource.com/1220869
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#590583}
aarongable
pushed a commit
that referenced
this pull request
Sep 18, 2018
RenderWidgets sometimes have a LayerTreeView created for them by the time Init() is run, sometimes they do not, and sometimes they never create one. This subtle indirect state is used to determine if the RenderWidget should use a compositor thread input task runner or not. We make this explicit instead of depending on ordering. Further, we note that the initialization of WebPagePopupImpl has boolean return values which can never be false, and tests null cases which do not occur, so we remove those return values and branches. Analysis #0: RenderViewImpl-attached RenderWidget. 1. RenderViewImpl::Initialize() makes a WebViewImpl, which does create a LayerTreeView from its constructor. 2. Then RenderViewImpl::Initialize() calls RenderWidget::Init(). This means RenderWidget::Init() does see a compositor present here. Analysis #1: Popups. 1. WebPagePopupImpl is created from WebViewImpl::OpenPagePopup(). It does RenderViewImpl::CreatePopup(), which makes the WebPagePopupImpl, via RenderWidget::CreateForPopup(). 2. CreateForPopup() also calls RenderWidget::Init(). 3. Then the stack unwinds to WebViewImpl which calls Initialize() on WebPagePopupImpl, which creates the LayerTreeView in RenderWidget. This means the RenderWidget::Init() call happens before the LayerTreeView exists, and there is no compositor present yet. Analysis #2: CreateForFrame() when |local_root| has a parent (making a non-main-Frame RenderWidget) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When there is a parent to the |local_root|, a WebFrameWidgetImpl is created. 3. A WebFrameWidgetImpl does not make a compositor in its constructor, but does later in its Initialize() method. The Initialize() call comes from WebFrameWidgetbase::BindLocalRoot() that is called from WebFrameWidget::Create() before returning to RenderWidget. This means RenderWidget::Init() does see a compositor present here. Analysis #3: CreateForFrame() when |local_root| has no parent (setting up the main Frame) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When for a main Frame, it makes a WebViewFrameWidget. 3. WebViewFrameWidget depends on being attached to a pre-existing WebViewImpl (and RenderViewImpl/RenderWidget) which has already set up a LayerTreeView, and thus does not set up another LayerTreeView on the new RenderWidget. 4. RenderWidget::CreateForFrame() does not make a new RenderWidget, it returns the existing one on the WebViewImpl. This means RenderWidget::Init() does not occur. R=awong@chromium.org, dcheng@chromium.org, piman@chromium.org TBR=jochen Change-Id: I84cc1c875245b755bd39f6890a839ecda71a20e4 Reviewed-on: https://chromium-review.googlesource.com/1227473 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592051}
aarongable
pushed a commit
that referenced
this pull request
Oct 5, 2018
…and use it for GetState"" This reverts commit 8aa00e1. Reason for revert: Causes crash on shutdown: Received signal 11 SEGV_MAPERR 000000000088 #0 0x7f228f7b5a3f base::debug::StackTrace::StackTrace() #1 0x7f228f7b5521 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f22832c80c0 <unknown> #3 0x7f228a01add1 std::__1::__tree<>::find<>() #4 0x7f228a0294dc dbus::ObjectManager::UnregisterInterface() #5 0x7f228a1978b3 bluez::BluetoothAdapterClientImpl::~BluetoothAdapterClientImpl() #6 0x7f228a1a05b0 bluez::BluetoothDBusClientBundle::~BluetoothDBusClientBundle() #7 0x7f228a1c808e bluez::BluezDBusManager::Shutdown() #8 0x559074b4094e ChromeBrowserMainPartsLinux::PostDestroyThreads() Original change's description: > Reland "bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState" > > This is a reland of 837b3c2 > > The original patch attempted to init the alternate dbus client on Linux where > there is no alternate bus connection. The latest patchset fixes this by > returning early if there is no alternate bus connection. > > TBRing since it's a minor addition to the original patch. > > Original change's description: > > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > > > There are two parts to this change: > > > > 1. Create a new BluetoothAdapterClient instance. For this we add > > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > > This new instance uses a separate DBus Connection through > > BluezDBusThreadManager. This ensures actions on one client won't > > affect the other client. > > > > 2. Implement BluetoothSystem::GetState using the new client. > > > > Bug: 870192, 882771 > > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Reviewed-by: Sam McNally <sammc@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#596520} > > TBR=stevenjb@chromium.org, derat@chromium.org, sammc@chromium.org, reillyg@chromium.org > > Bug: 870192, 882771 > Change-Id: I0e92cc90f095c6049b2b967e46249e8488f71fcb > Reviewed-on: https://chromium-review.googlesource.com/c/1263217 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596975} TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org,ortuno@chromium.org,sonnysasaka@chromium.org Change-Id: I92bd726f551e48e0b2013d9e58f76e10b90196ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870192, 882771 Reviewed-on: https://chromium-review.googlesource.com/c/1263639 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#596981}
aarongable
pushed a commit
that referenced
this pull request
Oct 16, 2018
This reverts commit c3e902d. Reason for revert: this cl causes linux MSAN cc_unittests failures: RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer RasterBufferProviderTests/RasterBufferProviderTest.MeasureGpuRasterDuration/2 LayerTreeHostPictureTestResizeViewportWithGpuRaster.RunSingleThread_DelegatingRenderer [ RUN ] RasterizeWithGpuRasterizationCreatesResources.RunMultiThread_DelegatingRenderer ==2667==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5974de0 in Do<long> ./../../base/numerics/safe_math_clang_gcc_impl.h:74:13 #1 0x5974de0 in Do<long> ./../../base/numerics/checked_math_impl.h:54:0 #2 0x5974de0 in MathOp<CheckedAddOp, long> ./../../base/numerics/checked_math.h:245:0 #3 0x5974de0 in operator+=<long> ./../../base/numerics/checked_math.h:339:0 #4 0x5974de0 in base::time_internal::SaturatedAdd(base::TimeDelta, long) ./../../base/time/time.cc:70:0 #5 0x49b3d8e in operator+ ./../../base/time/time.h:207:22 #6 0x49b3d8e in cc::GpuRasterBufferProvider::CheckRasterFinishedQueries() ./../../cc/raster/gpu_raster_buffer_provider.cc:558:0 Seems, GetQueryObjectuivEXT doesn't always initialize gpu_duration: GLuint gpu_duration; ri->GetQueryObjectuivEXT(it->query_id, GL_QUERY_RESULT_EXT, &gpu_duration); Original change's description: > gpu: Add UMA metric for measuring total raster task duration. > > Add an UMA metric which reports the accumulated time for a raster task > including the time from raster worker thread and the GPU main thread. > The GPU side timer takes care of only measuring time slices when the > decoder is processing commands. > > R=vmiura@chromium.org, piman@chromium.org > > BUG: 894200 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: If02a76420dbdf5ffb5041b8290412d144d787fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/1267235 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599870} TBR=enne@chromium.org,vmiura@chromium.org,holte@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org,piman@chromium.org Change-Id: I25b54841dca13aaa94cfc8dded8a40254f90d8e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1282519 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599926}
aarongable
pushed a commit
that referenced
this pull request
Oct 25, 2018
…enChanged() When running in single threaded mode, calls from OnBeginImplFrameDeadline() can make their way from the main thread to the impl thread, and then (erroneously) directly back to the main thread, causing a crash. See the stack trace below. With this CL, the call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied back to the main thread for the call to content::DelegatedFrameHost::OnFrameTokenChanged(). A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or surface_utils::ConnectWithLocalFrameSinkManager, and I did not want to change their existing behavior. So the additional task_runner parameter is defaulted to nullptr, and in that case the old behavior still applies - the call is not PostTasked. Example crash: [243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace() #1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace() #2 0x7f4d3b12a59b logging::LogMessage::~LogMessage() #3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit() #6 0x7f4d312b8205 cc::Layer::SetBackgroundColor() #7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation() #8 0x7f4d2cb79024 ui::LayerAnimator::SetColor() #9 0x7f4d2cb56a5c ui::Layer::SetColor() #10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor() #11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor() #12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation() #13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation() #14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_ #15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_ #16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv #19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame() #20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame() #21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView() #22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged() #23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged() #24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged() #25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged() #26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged() #27 0x7f4d1b61ab83 viz::Surface::ActivateFrame() #28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame() #29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded() #30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded() #31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded() #32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies() #33 0x7f4d1b6194f3 viz::Surface::QueueFrame() #34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal() #35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame() #36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame() #37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame() #38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers() #39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite() #40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible() #42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions() #43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline() #44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_ #46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv #49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_ #50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv #55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask() #56 0x7f4d3b14f466 base::MessageLoop::RunTask() #57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask() #58 0x7f4d3b14fc79 base::MessageLoop::DoWork() #59 0x7f4d3b1572b6 base::MessagePumpGlib::Run() #60 0x7f4d3b14eb5b base::MessageLoop::Run() #61 0x7f4d3b1fac6d base::RunLoop::Run() #62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun() #63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts() #64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run() #65 0x0000018caad1 (anonymous namespace)::RunOneTest() #66 0x0000018ca696 (anonymous namespace)::RunTests() #67 0x0000018ca11d LayoutTestBrowserMain() #68 0x0000018c82c0 content::ShellMainDelegate::RunProcess() #69 0x7f4d39305d5a content::RunBrowserProcessMain() #70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run() #71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #72 0x7f4d13359c2a service_manager::Main() #73 0x7f4d393034b3 content::ContentMain() #74 0x00000075e165 main #75 0x7f4d13dcd2b1 __libc_start_main #76 0x00000075e02a _start Bug: 667551 Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803 Reviewed-on: https://chromium-review.googlesource.com/c/1297477 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#602912}
aarongable
pushed a commit
that referenced
this pull request
Apr 30, 2024
Change-Id: I9f9f0b0aea5661d29f8f4ca5780d3c8dd8b31987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5499478 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6449@{#3} Cr-Branched-From: 13d05de-refs/heads/main@{#1293886}
aarongable
pushed a commit
that referenced
this pull request
Apr 30, 2024
Change-Id: I3d4effe58cde860e9a228fbc526865b6efbbc571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502169 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6450@{#3} Cr-Branched-From: 93d2ea9-refs/heads/main@{#1294268}
aarongable
pushed a commit
that referenced
this pull request
Apr 30, 2024
Stable release of Builtin HLS exposed missing features around encrypted content as well as livestreaming. This change disables the feature by default. (cherry picked from commit ad55613) Bug: 336837266 Bug: b/337072556 Bug: 336930736 Change-Id: Ie2b964ad7e6b939fb6125c98df58ccd2c9444af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498101 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1293991} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5500543 Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367_54@{#3} Cr-Branched-From: cd0e5b0-refs/branch-heads/6367@{#791} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
May 1, 2024
Change-Id: Ieea0b0b3b62973aac9dc15992dfbf02a25de8922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504909 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6451@{#3} Cr-Branched-From: 122d008-refs/heads/main@{#1294691}
aarongable
pushed a commit
that referenced
this pull request
May 1, 2024
Change-Id: Ife959d79d88feb5dc13e8d759470df270edbc2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503614 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6452@{#3} Cr-Branched-From: dc6e5f1-refs/heads/main@{#1294836}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2024
Change-Id: Ib41613d4aa111929c130ecb3e48482fd480fbe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5508074 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6453@{#3} Cr-Branched-From: 8c4dd4b-refs/heads/main@{#1295187}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2024
This reverts commit 5b98671. Reason for revert: browser_test failures starting at https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/41245/blamelist The failures all have stack: 2024-05-01T22:20:26.913799Z ERROR browser_tests[68320:68386]: [object_proxy.cc(576)] Failed to call method: org.chromium.debugd.GetPerfOutputV2: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files #0 0x55f5d4f55172 base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1043:7] #1 0x55f5d4f4139e base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:241:20] #2 0x55f5d57d3a8a content::(anonymous namespace)::SignalHandler() [../../content/public/test/browser_test_base.cc:177:24] #3 0x7f9d71a42520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f) #4 0x55f5db0e82e7 ash::FwupdDownloadClientImpl::GetURLLoaderFactory() [../../chrome/browser/ui/ash/fwupd_download_client_impl.cc:21:44] #5 0x55f5d833381c ash::FirmwareUpdateManager::DownloadLvfsMirrorFile() [../../chromeos/ash/components/fwupd/firmware_update_manager.cc:1051:35] #6 0x55f5d83350c1 base::internal::DecayedFunctorTraits<>::Invoke<>() [../../base/functional/bind_internal.h:738:12] #7 0x55f5d8334f93 base::internal::Invoker<>::RunOnce() [../../base/functional/bind_internal.h:954:5] Original change's description: > fwupd: Add refresh metadata logic > > Download the jcat file from chromeos local mirror and store it in cache. > Copy the file to a gz file and unzip it. Read the contents to get the > latest firmware file name. Download that file from chromeos local mirror > and call UpdateMetadata on those 2 files. > > BUG=b:328637488 > TEST=autoninja chrome; manually check from logs > chromeos_unittests --gtest_filter=FwupdClientTest.* && > FirmwareUpdateManager* > > Change-Id: I5673ad909963c4436a580746db9b94dd1c1a4f1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444929 > Commit-Queue: Rishabh Agrawal <rishabhagr@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1295074} Bug: b:328637488 Change-Id: Ib753c1db9048f1acf693606ff7058d9820942f3b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5508951 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Owners-Override: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/main@{#1295258}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2024
Change-Id: I6af01ddae44fd58400537b95356b1d1b163a5a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5506518 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6454@{#3} Cr-Branched-From: f7321fe-refs/heads/main@{#1295404}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2024
Currently Blink uses specialized AXMenuList/AXMenuListPopup/ AXMenuListOption classes to override building of a <select size=1> subtree, and only allow <option> children. This is only used on some platforms. Other platforms use the ordinary AXNodeObject code. This removes the AXMenuList* subclasses (as well as AXMockObject, which is no longer necessary for the popup). The AXNodeObject implementation is used for <select> on all platforms. There are many reasons to do this: 1. Remove ~1300 lines of code, much of it scattered as special cases inside otherwise generic code. 2. Less brittle -- the special classes/case, including special tree building, were often a source of instability. 3. Because the subtree is now built using our general LayoutTreeBuilderTraversal code, can support arbitrary descendants thus unblocking a11y for the experimental stylable select. 4. Because of #3, can now support optgroup correctly for both types of <select>. The optgroup was previously supported in listbox selects only, and even there it was incorrect -- it was exposed as as a sibling of the options. Blink now exposes optgroup correctly for both types of selects, with the correct structure (the optgroup is a parent rather than a sibling). This now matches how Firefox exposes optgroup. Future changes can possibly deprecated the menuListValueChangedEvent, as well as roles menuListPopup (replace with generic container or listBox) and menuListOption (replace with listBoxOption). Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026 Change-Id: Ib0e551b6a26b5d976aa6aa0949d87f8959a217f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467030 Reviewed-by: Jacques Newman <janewman@microsoft.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1295735}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2024
Change-Id: I9350ec7670371ea442aa58d8c7bb0e3d7fbe7089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513223 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6455@{#3} Cr-Branched-From: f14acf8-refs/heads/main@{#1295598}
aarongable
pushed a commit
that referenced
this pull request
May 3, 2024
…group>" This reverts commit d6d489a. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5644655993552896 Sample build with failed test: https://ci.chromium.org/b/8749012979391630193 Affected test(s): [ninja://:blink_web_tests/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/plz-dedicated-worker-disabled/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fplz-dedicated-worker-disabled%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5644655993552896&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5467030&type=BUG Original change's description: > [A11y] Remove AXMenuList* special classes/cases, support <optgroup> > > Currently Blink uses specialized AXMenuList/AXMenuListPopup/ > AXMenuListOption classes to override building of a <select size=1> > subtree, and only allow <option> children. This is only used on > some platforms. Other platforms use the ordinary AXNodeObject > code. This removes the AXMenuList* subclasses (as well as > AXMockObject, which is no longer necessary for the popup). > The AXNodeObject implementation is used for <select> on all platforms. > > There are many reasons to do this: > 1. Remove ~1300 lines of code, much of it scattered as special cases > inside otherwise generic code. > 2. Less brittle -- the special classes/case, including special tree > building, were often a source of instability. > 3. Because the subtree is now built using our general > LayoutTreeBuilderTraversal code, can support arbitrary descendants > thus unblocking a11y for the experimental stylable select. > 4. Because of #3, can now support optgroup correctly for both types > of <select>. The optgroup was previously supported in > listbox selects only, and even there it was incorrect -- it was > exposed as as a sibling of the options. Blink now exposes optgroup > correctly for both types of selects, with the correct structure > (the optgroup is a parent rather than a sibling). This now matches > how Firefox exposes optgroup. > > Future changes can possibly deprecated the menuListValueChangedEvent, > as well as roles menuListPopup (replace with generic container or > listBox) and menuListOption (replace with listBoxOption). > > Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026 > Change-Id: Ib0e551b6a26b5d976aa6aa0949d87f8959a217f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467030 > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1295735} > Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026 Change-Id: I700b1e291b6303ffc328f25ec2d79b884fe1b906 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513667 Owners-Override: Michelle Chen <michellegc@google.com> Commit-Queue: Michelle Chen <michellegc@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1295924}
aarongable
pushed a commit
that referenced
this pull request
May 3, 2024
Change-Id: Ib87166089666632319fef0e14bb53dc1bcca7167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514482 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6456@{#3} Cr-Branched-From: 95c4432-refs/heads/main@{#1295887}
aarongable
pushed a commit
that referenced
this pull request
May 3, 2024
Change-Id: Ic66401c8b380a4745a63b3ae07dd20c9c369b8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515068 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6457@{#3} Cr-Branched-From: ab97581-refs/heads/main@{#1296030}
aarongable
pushed a commit
that referenced
this pull request
May 4, 2024
Change-Id: If0ae6f13560344393970a73746bd87b31507dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5516837 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6458@{#3} Cr-Branched-From: 95b48e8-refs/heads/main@{#1296459}
aarongable
pushed a commit
that referenced
this pull request
May 4, 2024
Change-Id: Idbaabc3c7b4853b3775311da136f9500cb91bec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515293 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6459@{#3} Cr-Branched-From: fa5451b-refs/heads/main@{#1296544}
aarongable
pushed a commit
that referenced
this pull request
May 5, 2024
Change-Id: If1fff769bbc78a45e3804cfc21d2400076234909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515724 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6460@{#3} Cr-Branched-From: 5aecec3-refs/heads/main@{#1296585}
aarongable
pushed a commit
that referenced
this pull request
May 5, 2024
Change-Id: I977d060c899ef88efad260f77dca14498f4f5469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512266 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6461@{#3} Cr-Branched-From: 996d129-refs/heads/main@{#1296624}
aarongable
pushed a commit
that referenced
this pull request
May 6, 2024
Change-Id: I990cf12c1175fabef76bf1e325b781b198334ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5517890 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6462@{#3} Cr-Branched-From: 8c5ce30-refs/heads/main@{#1296672}
aarongable
pushed a commit
that referenced
this pull request
May 6, 2024
Change-Id: I191d1adaee0058e38ac7e095f6edabb9c1f2cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514064 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6463@{#3} Cr-Branched-From: 04a738e-refs/heads/main@{#1296775}
aarongable
pushed a commit
that referenced
this pull request
May 7, 2024
Change-Id: I66e8b5bd423369cf63df7f780347401cd24dc92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512513 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6464@{#3} Cr-Branched-From: 9f71be6-refs/heads/main@{#1297235}
aarongable
pushed a commit
that referenced
this pull request
May 7, 2024
Change-Id: I485f0bdb837a5bc7107f7264455c014dbcf4b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521794 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6465@{#3} Cr-Branched-From: 0fed283-refs/heads/main@{#1297435}
aarongable
pushed a commit
that referenced
this pull request
May 7, 2024
…group>" PLEASE DO NOT REVERT FOR TAST FAILURES -- The fix in CL:5516014 is in a different repo so has to land separately. This is a reland of commit d6d489a Reason for revert: Sample build with failed test: https://ci.chromium.org/b/8749012979391630193 Affected test(s): [ninja://:blink_web_tests/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659) [ninja://:blink_web_tests/virtual/plz-dedicated-worker-disabled/http/tests/inspector-protocol/accessibility/accessibility-ignoredNodes.js] (https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fplz-dedicated-worker-disabled%2Fhttp%2Ftests%2Finspector-protocol%2Faccessibility%2Faccessibility-ignoredNodes.js?q=VHash%3Ad656188f56ce4659) These are fixed in the latest patchset (original code in patchset 1). Fix was to not attempt to compute accessible name for menu list popup. Also broke https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/31806/overview: arc.Print.container_p inputs.PhysicalKeyboardKoreanTyping These are fixed by https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/5516014, which is in a different repro so must land separately. Fix was to change tests to look for menulistoption role instead of listboxoptionrole. Original change's description: > [A11y] Remove AXMenuList* special classes/cases, support <optgroup> > > Currently Blink uses specialized AXMenuList/AXMenuListPopup/ > AXMenuListOption classes to override building of a <select size=1> > subtree, and only allow <option> children. This is only used on > some platforms. Other platforms use the ordinary AXNodeObject > code. This removes the AXMenuList* subclasses (as well as > AXMockObject, which is no longer necessary for the popup). > The AXNodeObject implementation is used for <select> on all platforms. > > There are many reasons to do this: > 1. Remove ~1300 lines of code, much of it scattered as special cases > inside otherwise generic code. > 2. Less brittle -- the special classes/case, including special tree > building, were often a source of instability. > 3. Because the subtree is now built using our general > LayoutTreeBuilderTraversal code, can support arbitrary descendants > thus unblocking a11y for the experimental stylable select. > 4. Because of #3, can now support optgroup correctly for both types > of <select>. The optgroup was previously supported in > listbox selects only, and even there it was incorrect -- it was > exposed as as a sibling of the options. Blink now exposes optgroup > correctly for both types of selects, with the correct structure > (the optgroup is a parent rather than a sibling). This now matches > how Firefox exposes optgroup. > > Future changes can possibly deprecated the menuListValueChangedEvent, > as well as roles menuListPopup (replace with generic container or > listBox) and menuListOption (replace with listBoxOption). > > Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026 > Change-Id: Ib0e551b6a26b5d976aa6aa0949d87f8959a217f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467030 > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1295735} Bug: 40799465,40791317,41490722,40799465,40720672,40146374,41373952,41339236,41490165,338201026 Change-Id: I1b49004ad726456baf564d1d5e940174fe590c6e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513503 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Jacques Newman <janewman@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1297838}
aarongable
pushed a commit
that referenced
this pull request
May 8, 2024
Change-Id: I6219575aae4dda8c4f8f5f443d3c11fa9eda2925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521883 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6466@{#3} Cr-Branched-From: d2d4c1b-refs/heads/main@{#1297864}
aarongable
pushed a commit
that referenced
this pull request
May 8, 2024
Change-Id: Ic0c22d3176e19803e9d4f5ea40ec852eb6c12946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526954 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6467@{#3} Cr-Branched-From: 94c4d4c-refs/heads/main@{#1298042}
aarongable
pushed a commit
that referenced
this pull request
May 8, 2024
(cherry picked from commit b2cc7b7) (cherry picked from commit 072039f) Fixed: 339266700 Change-Id: I8c0ea8c540948016346b00db64fe33260d2446f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523748 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Original-Original-Commit-Position: refs/heads/main@{#1298119} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5527321 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Original-Commit-Position: refs/branch-heads/6367@{#1129} Cr-Original-Branched-From: d158c6d-refs/heads/main@{#1274542} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526235 Owners-Override: Daniel Yip <danielyip@google.com> Reviewed-by: Daniel Yip <danielyip@google.com> Commit-Queue: Erhu Akpobaro <eakpobaro@google.com> Reviewed-by: Erhu Akpobaro <eakpobaro@google.com> Cr-Commit-Position: refs/branch-heads/6367_159@{#3} Cr-Branched-From: 5016b4f-refs/branch-heads/6367@{#1101} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
May 9, 2024
Change-Id: Id279eff8c8c4684c55e4815d5552e0332c4bd60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528993 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6468@{#3} Cr-Branched-From: 9a70062-refs/heads/main@{#1298436}
aarongable
pushed a commit
that referenced
this pull request
May 9, 2024
Change-Id: Ib059b141371be60184ecf71bb758c4278eecc45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5525860 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6469@{#3} Cr-Branched-From: 3416991-refs/heads/main@{#1298568}
aarongable
pushed a commit
that referenced
this pull request
May 10, 2024
Change-Id: I5438020d1ddcb50ec86edf197f2baa2313612265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529864 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6470@{#3} Cr-Branched-From: 42d0122-refs/heads/main@{#1299020}
aarongable
pushed a commit
that referenced
this pull request
May 10, 2024
Roll src/v8 from c6b8b43c3042 to ac8da461a202 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/c6b8b43c3042..ac8da461a202 Generated by: http://go/bbid/8748321227209147585 Change-Id: I40d4309cafbca9da6d480459f1b2a42f53944ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526282 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367_201@{#3} Cr-Branched-From: 46cf136-refs/branch-heads/6367@{#1130} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
May 10, 2024
Change-Id: I1e747a1c3bebffe15c575dcaa9a43a8c7f0ddf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5531982 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6471@{#3} Cr-Branched-From: a908ffe-refs/heads/main@{#1299119}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.