Skip to content

Commit

Permalink
[M115][Files]: Eliminate extra space between trash and options
Browse files Browse the repository at this point in the history
In crrev.com/4521362 in order to hide search in trash while preserving
transition events the display: none was replaced with visibility: none.
This however upsets the layout of the files. In this CL we force the
button to occupy no additional space.
Video: http://screencast/cast/NTQ1NjgzMjgxOTYyNTk4NHw4OTMzZTdjMi1mZg

(cherry picked from commit 9bc6e51)

Bug: b:283932818
Change-Id: I2f8d2a750f26442c57beecb265239a443ac2f7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4564176
Reviewed-by: Wenbo Jie <wenbojie@chromium.org>
Commit-Queue: Bo Majewski <majewski@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1148924}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569965
Cr-Commit-Position: refs/branch-heads/5790@{#211}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
Bo Majewski authored and Chromium LUCI CQ committed Jun 1, 2023
1 parent b4ce282 commit 1ecc8f3
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
9 changes: 9 additions & 0 deletions ui/file_manager/file_manager/foreground/css/file_manager.css
Expand Up @@ -807,7 +807,12 @@ body.check-select #cancel-selection-button-wrapper {

/* Search button */
body.check-select-v1 #search-button {
border: 0;
margin: 0;
min-width: 0;
padding: 0;
visibility: hidden;
width: 0;
}

/* Search box */
Expand All @@ -828,6 +833,10 @@ body.check-select-v1 #search-button {
caret-color: var(--cr-input-color);
}

body.check-select-v1 #search-box {
visibility: hidden;
}

.dialog-header.files-ng #search-box.has-cursor,
.dialog-header.files-ng #search-box.has-text,
.dialog-header.files-ng #search-box.hide-pending {
Expand Down
Expand Up @@ -655,7 +655,12 @@ body.check-select #cancel-selection-button-wrapper {

/* Search button */
body.check-select-v1 #search-button {
border: 0;
margin: 0;
min-width: 0;
padding: 0;
visibility: hidden;
width: 0;
}

/* Search box */
Expand All @@ -670,6 +675,10 @@ body.check-select-v1 #search-button {
margin-inline-end: 16px;
}

body.check-select-v1 #search-box {
visibility: hidden;
}

.dialog-header.files-ng #search-box.has-cursor,
.dialog-header.files-ng #search-box.has-text,
.dialog-header.files-ng #search-box.hide-pending {
Expand Down

0 comments on commit 1ecc8f3

Please sign in to comment.