-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Local Network Access] Rename private to local in request.cc
In WICG/private-network-access#91, we decided to rename (public, private, local) IP address spaces to (public, local, loopback). The spec has already been renamed in WICG/private-network-access#97. New spec: https://wicg.github.io/local-network-access/#ip-address-space-heading This CL renames the string representation in request.cc. It also updates a mixed content wpt because it uses targetAddressSpace defined in Request. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1115707}
- Loading branch information
1 parent
e5e6e4f
commit 3037cbc
Showing
6 changed files
with
139 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 38 additions & 38 deletions
76
.../wpt/fetch/private-network-access/mixed-content-fetch.tentative.https.window-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,56 +1,56 @@ | ||
This is a testharness.js-based test. | ||
Found 52 tests; 41 PASS, 11 FAIL, 0 TIMEOUT, 0 NOTRUN. | ||
PASS https-loopback to http-loopback: wrong targetAddressSpace "unknown". | ||
PASS https-loopback to http-loopback: wrong targetAddressSpace "local". | ||
PASS https-loopback to http-loopback: wrong targetAddressSpace "public". | ||
PASS https-loopback to http-loopback: not a local network request. | ||
PASS https-loopback to http-local: wrong targetAddressSpace "unknown". | ||
PASS https-loopback to http-local: wrong targetAddressSpace "loopback". | ||
PASS https-loopback to http-local: wrong targetAddressSpace "public". | ||
PASS https-loopback to http-local: not a local network request. | ||
PASS https-loopback to http-public: wrong targetAddressSpace "unknown". | ||
PASS https-loopback to http-public: wrong targetAddressSpace "loopback". | ||
PASS https-loopback to http-public: wrong targetAddressSpace "local". | ||
PASS https-loopback to http-public: not a local network request. | ||
PASS https-local to http-loopback: missing targetAddressSpace. | ||
PASS https-local to http-loopback: wrong targetAddressSpace "unknown". | ||
PASS https-local to http-loopback: wrong targetAddressSpace "local". | ||
PASS https-local to http-loopback: wrong targetAddressSpace "public". | ||
PASS https-local to http-loopback: failed preflight. | ||
FAIL https-local to http-loopback: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-local to http-loopback: PUT success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-local to http-loopback: no-cors success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-local to http-local: wrong targetAddressSpace "unknown". | ||
PASS https-local to http-local: wrong targetAddressSpace "private". | ||
PASS https-local to http-local: wrong targetAddressSpace "loopback". | ||
PASS https-local to http-local: wrong targetAddressSpace "public". | ||
PASS https-local to http-local: not a private network request. | ||
PASS https-local to http-private: wrong targetAddressSpace "unknown". | ||
PASS https-local to http-private: wrong targetAddressSpace "local". | ||
PASS https-local to http-private: wrong targetAddressSpace "public". | ||
PASS https-local to http-private: not a private network request. | ||
PASS https-local to http-local: not a local network request. | ||
PASS https-local to http-public: wrong targetAddressSpace "unknown". | ||
PASS https-local to http-public: wrong targetAddressSpace "loopback". | ||
PASS https-local to http-public: wrong targetAddressSpace "local". | ||
PASS https-local to http-public: wrong targetAddressSpace "private". | ||
PASS https-local to http-public: not a private network request. | ||
PASS https-private to http-local: missing targetAddressSpace. | ||
PASS https-private to http-local: wrong targetAddressSpace "unknown". | ||
PASS https-private to http-local: wrong targetAddressSpace "private". | ||
PASS https-private to http-local: wrong targetAddressSpace "public". | ||
PASS https-private to http-local: failed preflight. | ||
FAIL https-private to http-local: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-private to http-local: PUT success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-private to http-local: no-cors success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-private to http-private: wrong targetAddressSpace "unknown". | ||
PASS https-private to http-private: wrong targetAddressSpace "local". | ||
PASS https-private to http-private: wrong targetAddressSpace "public". | ||
PASS https-private to http-private: not a private network request. | ||
PASS https-private to http-public: wrong targetAddressSpace "unknown". | ||
PASS https-private to http-public: wrong targetAddressSpace "local". | ||
PASS https-private to http-public: wrong targetAddressSpace "private". | ||
PASS https-private to http-public: not a private network request. | ||
PASS https-local to http-public: not a local network request. | ||
PASS https-public to http-loopback: missing targetAddressSpace. | ||
PASS https-public to http-loopback: wrong targetAddressSpace "unknown". | ||
PASS https-public to http-loopback: wrong targetAddressSpace "local". | ||
PASS https-public to http-loopback: wrong targetAddressSpace "public". | ||
PASS https-public to http-loopback: failed preflight. | ||
FAIL https-public to http-loopback: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-loopback: PUT success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-loopback: no-cors success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-public to http-local: missing targetAddressSpace. | ||
PASS https-public to http-local: wrong targetAddressSpace "unknown". | ||
PASS https-public to http-local: wrong targetAddressSpace "private". | ||
PASS https-public to http-local: wrong targetAddressSpace "loopback". | ||
PASS https-public to http-local: wrong targetAddressSpace "public". | ||
PASS https-public to http-local: failed preflight. | ||
FAIL https-public to http-local: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-local: PUT success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-local: no-cors success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-public to http-private: missing targetAddressSpace. | ||
PASS https-public to http-private: wrong targetAddressSpace "unknown". | ||
PASS https-public to http-private: wrong targetAddressSpace "local". | ||
PASS https-public to http-private: wrong targetAddressSpace "public". | ||
PASS https-public to http-private: failed preflight. | ||
FAIL https-public to http-private: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-private: PUT success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
FAIL https-public to http-private: no-cors success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-public to http-public: wrong targetAddressSpace "unknown". | ||
PASS https-public to http-public: wrong targetAddressSpace "loopback". | ||
PASS https-public to http-public: wrong targetAddressSpace "local". | ||
PASS https-public to http-public: wrong targetAddressSpace "private". | ||
PASS https-public to http-public: not a private network request. | ||
PASS https-treat-as-public to http-local: wrong targetAddressSpace "private". | ||
PASS https-public to http-public: not a local network request. | ||
PASS https-treat-as-public to http-loopback: wrong targetAddressSpace "local". | ||
FAIL https-treat-as-public to http-loopback: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-treat-as-public to http-local: wrong targetAddressSpace "loopback". | ||
FAIL https-treat-as-public to http-local: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
PASS https-treat-as-public to http-private: wrong targetAddressSpace "local". | ||
FAIL https-treat-as-public to http-private: success. assert_equals: error expected (undefined) undefined but got (string) "TypeError: Failed to fetch" | ||
Harness: the test ran to completion. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.