Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Windows PDBs default to using a page size of 4 KiB and have a maximum of 2^20 pages. This gives them a maximum size of 4 GiB which Chrome's test binaries have already started exceeding in some configuration, and chrome.dll is rapidly approaching. This problem was anticipated in 2020 (https://developercommunity.visualstudio.com/t/pdb-limit-of-4-gib-is-likely-to-be-a-problem-in-a/904784) and windbg, the Visual Studio debugger, the Visual Studio linker, the lld linker, Windows Performance Analyzer, and other tools were updated to support larger page sizes and therefore larger PDBs. Separately, another limitation of 4 KiB PDB pages was found when doing ARM64 Windows builds of Chrome, documented here: https://bugs.chromium.org/p/chromium/issues/detail?id=1406510#c32 Large PDBs require an updated version of dbghelp.dll, but we have long been prevented from updating dbghelp.dll because newer versions of the debugger tools don't work on Windows 7. Now that Windows 7 is no longer supported we are finally able to upgrade dbghelp.dll. Therefore this change: - changes the default value of use_large_pdbs to true, switching us to an 8 KiB page size, allowing 8 GiB PDBs. This page size can be trivially increased if needed in the future. - changes the toolchain hash to one with the new Debuggers directory (details below) - Adds $root_out_dir/dbghelp.dll to runtime_libs so that we deploy dbghelp.dll to all test bots. Because large PDBs fail with the version of dbghelp.dll that we have in the toolchain package this change also includes the hash of a new toolchain package. This was created by copying over the five main directories from the Debuggers directory from the Windows 11 SDK (version 10.0.22621.755) to the current packaged toolchain and repackaging. The commands to do this are: cd "third_party\depot_tools\win_toolchain\vs_files\1023ce2e82\Windows Kits\10\Debuggers" rmdir . /s/q xcopy "c:\Program Files (x86)\Windows Kits\10\Debuggers" . /s/v >nul rmdir arm /s/q rmdir ddk /s/q rmdir redist /s/q cd ..\..\..\.. call python3 ..\package_from_installed.py --repackage 1023ce2e82 Bug: 1273169, 1245726, 1406510 Change-Id: Ic1cd02c6b38bb1b8eb2b6a6ec542a7ff29f644a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4221084 Commit-Queue: Wanda Mora <morawand@google.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/branch-heads/5573@{#3} Cr-Branched-From: eee749f-refs/heads/main@{#1099765}
- Loading branch information