-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Fix an edge case bug in Windows TSF1 implementation."
This reverts commit 7ab2e8d. Reason for revert: cause regression in Omnibox with Korean autocomplete feature. Original change's description: > Fix an edge case bug in Windows TSF1 implementation. > > There is a bug in TSF1 impl where IME such as voice typing can select > text before composition start when user says "select that" command. In > this case, we need to select text that is before composition start. > > Bug: 1295578 > Change-Id: I873689569b542f8147a31d1b3837cdf543478875 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449664 > Reviewed-by: Yohei Yukawa <yukawa@chromium.org> > Commit-Queue: Siye Liu <siliu@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#971181} Bug: 1295578 Change-Id: I24e12bd23b10e20beeea4297d9274ed6029998db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572984 Reviewed-by: Siye Liu <siliu@microsoft.com> Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/4986@{#3} Cr-Branched-From: 248158e-refs/heads/main@{#988910}
- Loading branch information
Showing
2 changed files
with
0 additions
and
113 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters