Skip to content

Commit

Permalink
[AutofillFeedback] Add description placeholder.
Browse files Browse the repository at this point in the history
The CL adds a placeholder to the issue description section of the
autofill feedback form. Note that this targets an internal feature, so
no translation is necessary.

(cherry picked from commit 7385f0c)

Bug: 1407646, 1457142
Change-Id: I8bb5eec94a30c7a8d99b97bc33f2c1f278a1cc0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629310
Reviewed-by: Dominic Battre <battre@chromium.org>
Commit-Queue: Norge Vizcay <vizcay@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1161190}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641930
Reviewed-by: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/branch-heads/5845@{#134}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
  • Loading branch information
norgevz authored and Chromium LUCI CQ committed Jun 27, 2023
1 parent 4eb2b92 commit 4f3ebf3
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion chrome/browser/ui/autofill/autofill_context_menu_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ static constexpr int kAutofillContextCustomLast =
static constexpr int kAutofillContextFeedback =
IDC_CONTENT_CONTEXT_AUTOFILL_FEEDBACK;

constexpr char kFeedbackPlaceholder[] =
"What steps did you just take?\n"
"(1)\n"
"(2)\n"
"(3)\n"
"\n"
"What was the expected result?\n"
"\n"
"What happened instead? (Please include the screenshot below)";

base::Value::Dict LoadTriggerFormAndFieldLogs(
AutofillManager* manager,
content::RenderFrameHost* rfh,
Expand Down Expand Up @@ -246,7 +256,7 @@ void AutofillContextMenuManager::ExecuteAutofillFeedbackCommand(
chrome::ShowFeedbackPage(
browser_, chrome::kFeedbackSourceAutofillContextMenu,
/*description_template=*/std::string(),
/*description_placeholder_text=*/std::string(),
/*description_placeholder_text=*/std::string(kFeedbackPlaceholder),
/*category_tag=*/"dogfood_autofill_feedback",
/*extra_diagnostics=*/std::string(),
/*autofill_metadata=*/
Expand Down

0 comments on commit 4f3ebf3

Please sign in to comment.