Skip to content

Commit

Permalink
[MagicStack] Fix single tab module's layout.
Browse files Browse the repository at this point in the history
In this CL, we change the height of the tab thumbnail of the single tab
from 106dp to 112dp. It allows the height matches the price drop module.
Besides, remove a line in xml file to prevent the tab_url view in a
wrong layout position.
Phone after: https://screenshot.googleplex.com/5fNqxTotbSfqXs9
Tablet after: https://screenshot.googleplex.com/i3yRx7q7rKZHU9n

(cherry picked from commit a4764ad)

Bug: 1521541
Change-Id: I3ba8818aecaf133f0611769c4e205af886e3a4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234380
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1251835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238480
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#145}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
  • Loading branch information
Xi Han authored and Chromium LUCI CQ committed Jan 26, 2024
1 parent fda41e7 commit 71cce52
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ found in the LICENSE file.
android:layout_alignParentEnd="true"
android:layout_alignParentBottom="true"
android:layout_gravity="bottom"
android:layout_below="@+id/tab_title_view"
android:layout_toEndOf="@+id/tab_images"
android:gravity="start"
android:singleLine="true"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ found in the LICENSE file.
<dimen name="single_tab_module_lateral_margin">@dimen/mvt_container_lateral_margin_polish</dimen>
<dimen name="single_tab_module_padding_top">16dp</dimen>
<dimen name="single_tab_module_padding_bottom">20dp</dimen>
<dimen name="single_tab_module_tab_thumbnail_size_big">106dp</dimen>
<dimen name="single_tab_module_tab_thumbnail_size">@dimen/single_tab_module_tab_thumbnail_size_big</dimen>
<dimen name="single_tab_module_tab_thumbnail_size_big">112dp</dimen>
<dimen name="single_tab_module_tab_thumbnail_size">106dp</dimen>
<dimen name="single_tab_thumbnail_margin">1dp</dimen>
<dimen name="single_tab_thumbnail_radius">12dp</dimen>
<dimen name="favicon_padding">4dp</dimen>
Expand Down

0 comments on commit 71cce52

Please sign in to comment.