Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ByteArrayGenerator.java #145

Closed
wants to merge 1 commit into from
Closed

Update ByteArrayGenerator.java #145

wants to merge 1 commit into from

Conversation

samadpls
Copy link

@samadpls samadpls commented Dec 4, 2022

I removed an unnecessary condition.

@google-cla
Copy link

google-cla bot commented Dec 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@samadpls samadpls closed this Dec 5, 2022
@samadpls samadpls reopened this Dec 5, 2022
@samadpls samadpls closed this Dec 5, 2022
fujunwei pushed a commit to fujunwei/chromium that referenced this pull request Dec 8, 2022
@nickdiego
[M107] wayland: bypass xdg-activation calls during dnd sessions
9415cd8 
Gnome Shell xdg-activation implementation seems still buggy/unstable and
crashes were observed in Chrome's tab dragging. More specifically when
dragging a tab out and dropping it outside of any toplevel surface (eg:
on the desktop area), which is addressed in https://crrev.com/c/3913256
Besides that, more crashes were observed when, for example, on
repeatedly drags a tab in and out of its source window. Such crashes
usually bring the whole desktop session down. In order to overcome these
issues, this patches WaylandWindow::Activate to no-op while in
drag-and-drop sessions.

R=​mihlenfeldt@igalia.com

(cherry picked from commit c2f09f9)

Bug: 1366504
Test: Tested manually by repeatedly dragging Chrome tabs in and out.
Change-Id: I66fa0570c86ad666ee6ea35bd4146115bc45511c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914262
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Alexander Dunaev <adunaev@igalia.com>
Cr-Original-Commit-Position: refs/heads/main@{#1050544}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917151
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{chromium#145}
Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
wendachuan pushed a commit to wendachuan/chromium that referenced this pull request Jan 7, 2023
VCN upstream enrollment for Clank bug fix
d81c38a 
Build flag protect avatar animation check in VirtualCardEnrollmentManager::OnDidGetDetailsForEnrollResponse for Clank.

(cherry picked from commit ec727b4)

Bug: 1300383
Change-Id: I69ba2151fc12a9164ecb40e5e1f38e6e19846c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3486537
Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#974840}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3492797
Auto-Submit: Vishwas Uppoor <vishwasuppoor@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/branch-heads/4896@{chromium#145}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
MaoHan001 pushed a commit to riscv-android-src/chromium that referenced this pull request Jan 17, 2023
@ckitagawa-work
[M109] Binding Manager Connection Limit: Additional Metrics
bb41edd 
Additional metric recording:
* Waived binding OOM count.
* Number of times bindings are dropped from hitting the BindingManager
  max connection limit.

These metrics should help inform whether the BindingManagerConnection
limit experiment makes sense to launch.

(cherry picked from commit 1b56458)

Bug: 1385812
Change-Id: I55a278f5f6a43ca08756674b8f4677efec0902ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031089
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1073004}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037287
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/branch-heads/5414@{chromium#145}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
blueboxd referenced this pull request in blueboxd/chromium-legacy Feb 8, 2023
Revert "Reland "[Read Anything] Set maximum side panel width during r…
e3a816b 
…esizing.""

This reverts commit 158e380.

Reason for revert: Caused crbug.com/1402915.

Original change's description:
> Reland "[Read Anything] Set maximum side panel width during resizing."
>
> This is a reland of commit 7fc7a9b
>
> What changed: Use content_container rather than content_web_view for
> the maximum width calculation of side panel. Content_container also
> includes dev tools, while content_web_view does not. Side panel
> computation should be based on the entire contents, including dev tools.
>
> Original change's description:
> > [Read Anything] Set maximum side panel width during resizing.
> >
> > Current side panel resizing rules:
> > 1. The minimum browser window width is 500
> >    (kMainBrowserContentsMinimumWidth).
> > 2. The minimum side panel width is 320.
> > 3. The side panel can be widened up until it leaves 500 - 320 = 180
> >    in the main web contents.
> >
> > Proposed side panel resizing rules:
> > 1. The minimum window width remains at its current 500.
> > 2. The minimum main web contents width remains at its current 180.
> > 3. At 500px, the side panel is 320 and the main web contents is
> >    180px, as before the proposal.
> > 4. Between window width = 500 to 820, the side panel remains at
> >    320px and the main contents increases in width.
> > 5. At window width > 820, side panel can now be widened. It cannot
> >    go wider than a width that would keep the main contents at least
> >    at 500.
> >
> > The motivation for this change is that the current behavior, which
> > allows side panel to be resized up to leaving the main web contents
> > at 180, even when the browser window size is very large:
> > https://screenshot.googleplex.com/9Fr9axFE4hfJWFE. For Read Anything
> > we would like to remove this possibility.
> >
> > For more context and alternatives, see
> > https://docs.google.com/document/d/1qfuhKHWrveRc5UQ37KdFGMDvt2JypvyU_4h8ejNfips/edit#
> >
> > Bug: 1329585, 1266555
> > Change-Id: I166760e168809db6400e12c5c359ef681c7879d3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000980
> > Reviewed-by: Peter Boström <pbos@chromium.org>
> > Commit-Queue: Abigail Klein <abigailbklein@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1076212}
>
> Bug: 1329585, 1266555
> Change-Id: Ic15fa8d951da9bb7b74675d33d112131477a5bb5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098251
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Commit-Queue: Abigail Klein <abigailbklein@google.com>
> Cr-Commit-Position: refs/heads/main@{#1082187}

(cherry picked from commit 5fa5328)

Bug: 1329585, 1266555, 1402915
Change-Id: I57e11b37e7e42c443535df385cc66400f894f946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4116724
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Emily Shack <emshack@chromium.org>
Auto-Submit: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Emily Shack <emshack@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1086416}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133333
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#145}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai pushed a commit to chirayudesai/chromium that referenced this pull request Mar 7, 2023
@ChristianXuG
[iOS][Omnibox][M111] Fix row trailing constraint
7777aa4 
Fix trailing anchor constraint.
stackView.trailing = contentView.trailing - constant
instead of
stackView.trailing = contentView.trailing + constant

(cherry picked from commit 04b2c64)

Bug: 1411903
Change-Id: Ia84c1c0b95633cc90f8adf034bb800f37de9aa5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4212389
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Christian Xu <christianxu@chromium.org>
Commit-Queue: Christian Xu <christianxu@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1100006}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219100
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#145}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit pushed a commit to CalyxOS/chromium that referenced this pull request Mar 31, 2023
@edx246
[ios] Add finch params for Foreground Refresh
a3f8f5b 
(cherry picked from commit 2ecfdcd)

Bug: 1418430
Change-Id: I5a7680c22c6fb0af345d39bb23ee691c42fee08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300422
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1111983}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303133
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: edchin <edchin@google.com>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#145}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
unicornx pushed a commit to unicornx/chromium that referenced this pull request Apr 19, 2023
[NTP][RecipesV1.1] Add new string for recipes v1.1 info dialog
b0c2d9c 
Removed the word "suggested" in the info dialog for Recipes v1.1
experiment arms since that verbiage won't make sense on the historical arm.

Screenshot:
IDS_NTP_MODULES_RECIPE_EXTENDED_INFO: screenshot/76sZjuEiXsHkTKm

(cherry picked from commit e6fe363)

Bug: 1346070
Change-Id: Ib7adf3207ed462e9f6235d3173226e91ee352129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791651
Commit-Queue: Riley Tatum <rtatum@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1029470}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795716
Auto-Submit: Riley Tatum <rtatum@google.com>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5195@{chromium#145}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
l0hn pushed a commit to l0hn/chromium_test that referenced this pull request Jun 9, 2023
@adangla
[iOS] Enable edit button when no active but inactive tabs
9649237 
When a user is in the regular tab grid, the "Close All" option should be
available if there is inactive tab to close even if there is no actives.
This CL add dynamic update to the Edit button in the following scenario:
* When the regular tab grid is empty but there is inactive tabs then
"Edit" button is available and only have "Close All" options
See video:
https://drive.google.com/file/d/1yDpOQjaMNaqyLbCOTlFTT68ctFWZHpMl/view?usp=share_link
* When there is no active nor inactive then "Edit" is not available
See screenshot:
https://drive.google.com/file/d/1U_6s-UQBYjYZgte_6GbN0rukRz29qAGC/view?usp=share_link
* For incognito, the "Edit" button should behave as before
See video:
https://drive.google.com/file/d/1Z7EJnpHT4X9G8KcrtrYursPPcfj0MGDC/view?usp=share_link

(cherry picked from commit 9bee1ec)

Fixed: 1434217
Change-Id: I8e14eff68554f1252647f67f685339fc6e46b467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481598
Reviewed-by: Louis Romero <lpromero@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1137170}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498428
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Aliona Dangla <alionadangla@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{chromium#145}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1 pushed a commit to qtmlabs/chromium that referenced this pull request Jun 29, 2023
@kleerwater
[M116][infra] Remove the need to use $mixin_append.
e468e84 
The $mixin_append field is used for appending rather than overwriting
any of the various *args fields or the named_caches field of the
swarming field, but there are no uses of the *args fields that are not
in $mixin_append and none of the non-$mixin_append occurrences of
named_caches is overwriting any other value. This simplifies the
behavior so that named_caches and *args fields will always be appended
rather than requiring the $mixin_append field. Once all mixins.pyl files
are updated, the $mixin_append handling can be removed.

(cherry picked from commit 4c35b14)

Bug: 1456553
Change-Id: Ic29508b2b86ac47f3f70472de6e97aadfe6beaf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632065
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1161935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651928
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#145}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
debugeek pushed a commit to debugeek/chromium that referenced this pull request Jul 6, 2023
Roll ChromeOS Atom AFDO profile from 102-4951.6-1648466692-benchmark-…
32c853a 
…102.0.4969.0-r1 to 102-4992.0-1650276262-benchmark-102.0.5005.20-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I7e6eba0128f8394c9f6e3d04474303cce82d9ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3605853
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5005@{chromium#145}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
@carlosjoan91
Add metrics for https upgrades omnibox escape hatch
7102590 
This adds a new bucket to NavigationRequestSecurityLevel that is logged
when a navigation is opted out from upgrades due to the URL including
an explicit http:// scheme.

(cherry picked from commit 9e60488)

Bug: 1447921
Change-Id: I985fdf0e6bba12ce224906149723fac47e0798b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568799
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149472}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574275
Cr-Commit-Position: refs/branch-heads/5790@{chromium#145}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
Roll ChromeOS Arm AFDO profile from 118-5938.29-1693827733-benchmark-…
b6fdde3 
…118.0.5993.9-r1 to 118-5938.29-1693827733-benchmark-118.0.5993.10-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I8e181f4860913482c0e042769bc34203110a92d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855674
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#145}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Win64 PGO Profile
8c0abff 
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696614294-8df28bb22d8071db0e9e2c5ba184874386b4f705.profdata to chrome-win64-6045-1696636250-669acfb4898056f3e02517d47eded063bbc18e51.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I37fd0995c375b7f0c0251ef4ce5ff935a8824eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920306
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#145}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori referenced this pull request in Pissandshittium/pissandshittium Dec 8, 2023
Roll Chrome Mac PGO Profile
f76a74c 
Roll Chrome Mac PGO profile from chrome-mac-6099-1699009618-f5c32cf496f0347840192613b22084cb9d9b8965.profdata to chrome-mac-6099-1699033791-2f0401607d215261268bb6095cb0a5156db7518b.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie36325a00abefe9871f9b57e811c30ba173d6c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005423
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#145}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll Chrome Win64 PGO Profile
17e3cf0 
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702035211-4011e95312ea7dbedd47cf4b1770302146a402fe.profdata to chrome-win64-6167-1702057598-0abc8861485a17a91adec511ea8479814fb3e0d4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I440812858b0a91ae28e1598b1e92bb1d9c427a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5106310
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#145}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
[MagicStack] Fix single tab module's layout.
71cce52 
In this CL, we change the height of the tab thumbnail of the single tab
from 106dp to 112dp. It allows the height matches the price drop module.
Besides, remove a line in xml file to prevent the tab_url view in a
wrong layout position.
Phone after: https://screenshot.googleplex.com/5fNqxTotbSfqXs9
Tablet after: https://screenshot.googleplex.com/i3yRx7q7rKZHU9n

(cherry picked from commit a4764ad)

Bug: 1521541
Change-Id: I3ba8818aecaf133f0611769c4e205af886e3a4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234380
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1251835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238480
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#145}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable pushed a commit that referenced this pull request Feb 26, 2024
Automated Commit: LKGM 15786.8.0 for chromeos.
ca95151 
Uploaded by https://ci.chromium.org/b/8755069593818118961

Change-Id: I36cda761907eb2988b3c670a9bc1b759a5e1de59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324321
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#145}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
@fergald
Move deprecate-unload flag to the deprecated flags section.
480c229 
(cherry picked from commit d08e2c0)

Bug: 1432116,1472288
Change-Id: If363270b971584cc7c4717805d137cfeed04152c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4764528
Auto-Submit: Fergal Daly <fergal@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182184}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779739
Commit-Queue: Prudhvikumar Bommana <pbommana@google.com>
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Prudhvikumar Bommana <pbommana@google.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#145}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 23, 2024
Roll Chrome Win64 PGO Profile
8bc1f7d 
Roll Chrome Win64 PGO profile from chrome-win64-6367-1711129065-61a9f2317a93c4a9e019132eaa2ee729d11fc46d-73505ebaf922c5ea595491516502214af19090b0.profdata to chrome-win64-6367-1711149022-754eff8f1cbdab41da20f0fa4dcaca31d50d0f0e-8356c80d5c1f9b10c3f9535bd53faecae9152d59.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Icc48f9f7c50750f0860a5dbecf58b6d50aa0bcdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369184
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#145}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 19, 2024
[M125][Tab Group Parity] Change flags to use cached flags in some ins…
1c76b1e 
…tances

Change the TabGroupParity flag to use cached flags in some use cases.

(cherry picked from commit b4e62fe)

Bug: 335691911, 41490324
Change-Id: Ic728178978f7951e0a242ec001e831678d6a53b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462491
Commit-Queue: Brandon Fong <bjfong@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1289553}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468602
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/6422@{#145}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 17, 2024
Roll Chrome Linux PGO Profile
3736de6 
Roll Chrome Linux PGO profile from chrome-linux-6478-1715920730-3cb0920c0a1abc82d8883f9854e612ba6f1faf8c-d859044d722fc789b887690715f83b92749811ae.profdata to chrome-linux-6478-1715944004-0346ca5b106e622a2a584fbd3a57d36e8d2125b0-582cd3edc39dd59a36d814d4675db522ecf4ccf7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m126.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I1e9fd67ee31213e56d030a3766d02319f58d1fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545772
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#145}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request May 18, 2024
Updating XTBs based on .GRDs from branch 5249
f488e94 
Change-Id: I174d8a310b5147956c8b27ca9c5017309f7c8c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3860734
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{chromium#145}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
aarongable pushed a commit that referenced this pull request Jun 15, 2024
[M127][Android] Fix crash when signing out from CBD
a34b3e0 
The crash was caused by a scenario where ClearBrowsingDataFragment is
hosted in SettingsActivity indirectly via
ClearBrowsingDataTabsFragment (disable QuickDeleteAndroidFollowup
to trigger this behavior).
When ClearBrowsingDataFragment is instantiated indirectly - the code
in SettingsActivity to inject SnackbarManager doesn't trigger, so
mSnackbarManager in ClearBrowsingDataFragment was null, causing a
crash. This CL changes how ClearBrowsingDataFragment obtains
SnackbarManager (this code no longer depends on how
ClearBrowsingDataFragment is instantiated) and thus fixes the crash.

(cherry picked from commit b9ea978)

Bug: 344531913
Change-Id: I9dfb058528d877e206378083f36fd87e0782ecbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5625862
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1314509}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633419
Reviewed-by: Menghan Yang <myuu@google.com>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Menghan Yang <myuu@google.com>
Cr-Commit-Position: refs/branch-heads/6533@{#145}
Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samadpls