Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M127][Android] Fix crash when signing out from CBD
The crash was caused by a scenario where ClearBrowsingDataFragment is hosted in SettingsActivity indirectly via ClearBrowsingDataTabsFragment (disable QuickDeleteAndroidFollowup to trigger this behavior). When ClearBrowsingDataFragment is instantiated indirectly - the code in SettingsActivity to inject SnackbarManager doesn't trigger, so mSnackbarManager in ClearBrowsingDataFragment was null, causing a crash. This CL changes how ClearBrowsingDataFragment obtains SnackbarManager (this code no longer depends on how ClearBrowsingDataFragment is instantiated) and thus fixes the crash. (cherry picked from commit b9ea978) Bug: 344531913 Change-Id: I9dfb058528d877e206378083f36fd87e0782ecbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5625862 Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com> Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1314509} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633419 Reviewed-by: Menghan Yang <myuu@google.com> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Menghan Yang <myuu@google.com> Cr-Commit-Position: refs/branch-heads/6533@{#145} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
- Loading branch information