Skip to content

Commit

Permalink
Fix clicking on the scrim when an RS is active.
Browse files Browse the repository at this point in the history
The CS Panel was destroying the RS controls when it was told to close.
This means that destruction was happening at the time the close was
started rather than when the close was complete. The fix is to
simply remove these premature destroy calls. These destroy calls
are already being made at the correct time in the CS Panel method
destroyComponents which is called by the OverlayPanel when the
close completes.

BUG=1318546

(cherry picked from commit 0139aeb)

Change-Id: I95ab5cf54a1c5aec07c44f92ef355dfb2a0b1f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600947
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#995276}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3603920
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5005@{#137}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
  • Loading branch information
Donn Denman authored and Chromium LUCI CQ committed Apr 25, 2022
1 parent 28858fa commit b125933
Showing 1 changed file with 0 additions and 2 deletions.
Expand Up @@ -626,8 +626,6 @@ public void closePanel(@StateChangeReason int reason, boolean animate) {
ContextualSearchUma.logTabPromotion(activeRelatedSearches.isShowingRelatedSearchSerp());
mIsRelatedSearchesInContentSerp = false;
}
destroyInBarRelatedSearchesControl();
destroyInContentRelatedSearchesControl();
}

@Override
Expand Down

0 comments on commit b125933

Please sign in to comment.