Skip to content

Commit

Permalink
Revert "Re-enable TabindexFocusDownloads/FileManagerBrowserTest"
Browse files Browse the repository at this point in the history 
This reverts commit 1a6e52a.

Reason for revert: Re-enabled test is failing on Linux CrOS:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27415

[ RUN      ] TabindexFocusDownloads/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
[1570:1570:0511/120258.095371:WARNING:user_policy_manager_factory_chromeos.cc(207)] No policy loaded for known non-enterprise user
[1570:1570:0511/120258.202042:WARNING:user_session_manager.cc(1096)] Attempting to save user password for non enterprise user.
[1570:1570:0511/120300.805728:INFO:file_manager_browsertest_base.cc(632)] FileManagerBrowserTest::StartTest tabindexFocusDownloads
[1570:1570:0511/120306.899468:INFO:CONSOLE(1169)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1169)
[1570:1570:0511/120306.921159:INFO:CONSOLE(5028)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5028)
[1570:1570:0511/120306.988321:INFO:CONSOLE(4360)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4360)
[1570:1570:0511/120307.027400:INFO:CONSOLE(5030)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5030)
[1570:1570:0511/120307.030481:INFO:CONSOLE(5040)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040)
[1570:1570:0511/120307.036408:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443)
[1570:1570:0511/120307.107297:INFO:CONSOLE(5040)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040)
[1570:1570:0511/120307.107935:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443)
[1570:1570:0511/120307.497407:INFO:CONSOLE(5491)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491)
[1570:1570:0511/120307.537188:INFO:CONSOLE(5044)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044)
[1570:1570:0511/120307.892689:INFO:CONSOLE(5491)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491)
[1570:1570:0511/120307.896753:INFO:CONSOLE(5044)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044)
[1570:1570:0511/120307.897292:INFO:CONSOLE(5048)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5048)
[1570:1570:0511/120307.965385:INFO:CONSOLE(4357)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4357)
[1570:1570:0511/120312.721349:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[1570:1570:0511/120312.837968:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120315.831155:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120318.719753:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120322.994251:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120324.716075:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120327.609187:INFO:CONSOLE(0)] "[SUCCESS] [tabindexFocusDownloads]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[1570:1609:0511/120328.005035:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=10
[1570:1570:0511/120328.049612:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 3 in process 8
[1570:1570:0511/120328.049891:ERROR:frame_sink_provider_impl.cc(51)] No RenderWidgetHost exists with id 3 in process 8
[1570:1609:0511/120329.166852:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=20
[1570:1609:0511/120329.325388:WARNING:audio_sync_reader.cc(175)] ASR: No room in socket buffer.: Broken pipe (32)
[1570:1570:0511/120329.451110:WARNING:event_router.cc(421)] Not all file watchers are removed. This can happen when the Files app is open during shutdown.
[1570:1570:0511/120329.531088:FATAL:frame_sink_manager_impl.cc(58)] Check failed: sink_map_.empty().
#0 0x000000972721 (/b/s/w/ir/out/Release/browser_tests+0x972720)
#1 0x00000f472f9c (/b/s/w/ir/out/Release/browser_tests+0xf472f9b)
#2 0x00000f288153 (/b/s/w/ir/out/Release/browser_tests+0xf288152)
#3 0x00001617a0e7 (/b/s/w/ir/out/Release/browser_tests+0x1617a0e6)
#4 0x00001617a9ce (/b/s/w/ir/out/Release/browser_tests+0x1617a9cd)

Original change's description:
> Re-enable TabindexFocusDownloads/FileManagerBrowserTest
> 
> Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.
> 
> No-Presubmit: true
> Tbr: fukino
> Bug: 836254
> Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252
> Reviewed-on: https://chromium-review.googlesource.com/1055252
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557884}

TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org

Change-Id: I8b4ac33592cb5ff61a414416de04dea03f5d89da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836254
Reviewed-on: https://chromium-review.googlesource.com/1055216
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558004}
  • Loading branch information
@rdcronin
rdcronin authored and Commit Bot committed May 11, 2018
1 parent 9cfcbfc commit ba5ad5c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,13 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "tabindexFocus")));

#if defined(DISABLE_SLOW_FILESAPP_TESTS)
#define MAYBE_TabindexFocusDownloads DISABLED_TabindexFocusDownloads
#else
#define MAYBE_TabindexFocusDownloads TabindexFocusDownloads
#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
TabindexFocusDownloads,
MAYBE_TabindexFocusDownloads,
FileManagerBrowserTestWithLegacyEventDispatch,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
"tabindexFocusDownloads"),
Expand Down

0 comments on commit ba5ad5c

Please sign in to comment.