Skip to content

Commit

Permalink
[iOS] Add chrome://flags entry to enable password sharing
Browse files Browse the repository at this point in the history
Bug: 1298608
Change-Id: Ice1d0f2adcc1eaab0755f56ffeba520f6eaec2fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974610
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214871}
  • Loading branch information
Rafał Godlewski authored and Chromium LUCI CQ committed Oct 25, 2023
1 parent 4d1a682 commit e75d124
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/browser/flag-metadata.json
Expand Up @@ -6193,7 +6193,7 @@
},
{
"name": "password-sharing",
"owners": ["mamir@chromium.org", "chrome-password-manager-team@google.com"],
"owners": ["mamir@chromium.org", "rgod@google.com", "chrome-password-manager-team@google.com"],
"expiry_milestone": 125
},
{
Expand Down
13 changes: 13 additions & 0 deletions ios/chrome/browser/flags/about_flags.mm
Expand Up @@ -679,6 +679,16 @@
std::size(kOmniboxInspireMeWith20Total10Trends), "t3363285"},
};

const FeatureEntry::Choice kEnablePasswordSharingChoices[] = {
{"Default", "", ""},
{"Bootstraping Only", switches::kEnableFeatures,
"SharingOfferKeyPairBootstrap"},
{"Enabled", switches::kEnableFeatures,
"SharingOfferKeyPairBootstrap,SendPasswords,"
"PasswordManagerEnableSenderService,"
"PasswordManagerEnableReceiverService,SharedPasswordNotificationUI"},
};

// To add a new entry, add to the end of kFeatureEntries. There are four
// distinct types of entries:
// . ENABLE_DISABLE_VALUE: entry is either enabled, disabled, or uses the
Expand Down Expand Up @@ -1587,6 +1597,9 @@
{"enable-save-to-drive", flag_descriptions::kIOSSaveToDriveName,
flag_descriptions::kIOSSaveToDriveDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kIOSSaveToDrive)},
{"password-sharing", flag_descriptions::kPasswordSharingName,
flag_descriptions::kPasswordSharingDescription, flags_ui::kOsIos,
MULTI_VALUE_TYPE(kEnablePasswordSharingChoices)},
};

bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
Expand Down
4 changes: 4 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
Expand Up @@ -854,6 +854,10 @@ const char kPasswordReuseDetectionDescription[] =
"Displays warning when user types or pastes a saved password into a "
"phishing website.";

const char kPasswordSharingName[] = "Enables password sharing";
const char kPasswordSharingDescription[] =
"Enables password sharing between members of the same family.";

const char kPostRestoreDefaultBrowserPromoName[] =
"Post Restore Default Browser Promo";
const char kPostRestoreDefaultBrowserPromoDescription[] =
Expand Down
5 changes: 5 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
Expand Up @@ -750,6 +750,11 @@ extern const char kUseAnnotationsForLanguageDetectionDescription[];
extern const char kPasswordReuseDetectionName[];
extern const char kPasswordReuseDetectionDescription[];

// Title and description for the flag to enable password sharing between the
// members of the same family.
extern const char kPasswordSharingName[];
extern const char kPasswordSharingDescription[];

// Title and description for the flag to enable the post restore default browser
// promo.
extern const char kPostRestoreDefaultBrowserPromoName[];
Expand Down

0 comments on commit e75d124

Please sign in to comment.