-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance cookiemonster #220
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aarongable
pushed a commit
that referenced
this pull request
Apr 7, 2024
Change-Id: I28aea3825ef4514bb425b3a61bc047ccb4579655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5328967 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#220} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Apr 7, 2024
There seems to be an issue with quirks mode. (cherry picked from commit d95ae3e) Bug: 330753862 Change-Id: I6b25289dbb000445a8f3b1de7796f0daa58f354f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368267 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1277021} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390283 Cr-Commit-Position: refs/branch-heads/6367@{#220} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 7, 2024
Roll Chrome Mac PGO profile from chrome-mac-6261-1706498537-49dd14b6e1773217df8cdeb5fa0c5a5762661632.profdata to chrome-mac-6261-1706528519-92986bab10ee7a2bf5c0f4f69fe4bb385e2cd0db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9c3d91a66a9a9ad82bff460f18cdb5f1d18af810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5244223 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#220} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Apr 10, 2024
Roll Chrome Linux PGO profile from chrome-linux-6099-1699241318-5a3b3404dca17e0877136f36c818e070fd5b2b6f.profdata to chrome-linux-6099-1699268473-79a0df221cec0d31c3b051f8da5f0f0347476386.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fa326c7c67b65b5bebc4fa95cc1174e20af297e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5007770 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#220} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Apr 22, 2024
(Merge to release branch M125) - This makes sure cohorts are reset when Cookies are cleared. - It also sets metadata entries with source testing eligible for DTRP. This will be best appropriate for dummy entries. This is done in this CL to ease tag along with feature merge request. (cherry picked from commit a9b6a68) Bug: b:335409490 Change-Id: I9e6b6bc5a4842f8fbab0d8532f0963d98ed643d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458857 Reviewed-by: Anton Maliev <amaliev@chromium.org> Commit-Queue: Jonathan Njeunje <njeunje@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1289485} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473105 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jonathan Njeunje <njeunje@chromium.org> Cr-Commit-Position: refs/branch-heads/6422@{#220} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
ecotopian
pushed a commit
to ecosia/chromium-android-browser
that referenced
this pull request
Apr 25, 2024
Change-Id: I4104ed050f45b9ad601df70ef666feaa41c57ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923672 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#220} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
keyou
pushed a commit
to keyou/chromium
that referenced
this pull request
May 14, 2024
…hat doesn't exist. I found this while fixing the SidePanelCoordinatorTests, which I'll send out after this. If for some reason this gets called twice for a popped out button, the button will first be removed then the second time a button cannot be found which would cause a crash. (cherry picked from commit 7c1f821) Bug: 1509504 Change-Id: I395a9ebfaeb96995d1e968e6b1062eeaec252f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5099962 Reviewed-by: Darryl James <dljames@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1234632} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5111081 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Caroline Rising <corising@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{chromium#220} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
kaidokert
pushed a commit
to youtube/chrobalt_sandbox
that referenced
this pull request
May 18, 2024
Roll Chrome Mac PGO profile from chrome-mac-5735-1683115063-7d3781f49f63af205ad85599378265723b1ef9c4.profdata to chrome-mac-5735-1683134587-f8ad727874e6e03221f55ca1f181f511e97370e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m114.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifad7146ce2ce7be324a73bef88ae26f1923849ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503917 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{chromium#220} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable
pushed a commit
that referenced
this pull request
May 19, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1716071882-4ce33c9fd01d3a89330cef8da7baab3bc417725f-d0db0d9f06d08ce42b7aa6c2625febcc77564f11.profdata to chrome-mac-arm-6478-1716083048-39e11c19ef598e0f9d5734fa0ad80a9309763872-0f4d26d2c8a31a8e5abe957d0194fea4e6c513f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I885b50ae84a8d20bcc1079ceb1e4f2391a570e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548143 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#220} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Jun 17, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6533-1718492240-226c8e7cebfeb839e6b9a497a10baf1be116bc28-78b457df167e329d2104c9c24d3e3000234e30a8.profdata to chrome-mac-arm-6533-1718502866-9ca9c14083cf1b9d6bf9f3f4c379a35210960015-a8242a55163a28031f57a356cd754903b4b2b94b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Idda49d598eeefacb3223e9ef1bb700ca1e576ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635658 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6533@{#220} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.