Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form.css #170

Merged
merged 1 commit into from
May 17, 2019
Merged

Update form.css #170

merged 1 commit into from
May 17, 2019

Conversation

ZerooCool
Copy link
Contributor

The text is too long and goes out of the button.
Increase the size of the button.
My resolution: 1920x1080.

Decrease font-size: 1.4em;
Increase max-width: 22em;

.form input[type=text],
.form input[type=submit] {

font-size: 1.4em;

max-width: 22em;

}

The text is too long and goes out of the button.
Increase the size of the button.
My resolution: 1920x1080.  

Decrease font-size: 1.4em;
Increase max-width: 22em;

.form input[type=text],
.form input[type=submit] {

  font-size: 1.4em;

  max-width: 22em;

}
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ZerooCool
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ZerooCool
Copy link
Contributor Author

Replace max-width: 22em; by max-width: 25em;

@lgarron
Copy link
Collaborator

lgarron commented Feb 5, 2019

The button seems to have plenty of spare space for me at that resolution. Would you mind sharing screenshots before and after this change?

@ZerooCool
Copy link
Contributor Author

https://prnt.sc/mhp2k9

And, the second button to the bottom too, for the validation ( is not in my screen ).

I have test and my notification is correct : Need more space and small text.
You can validate this update, it's my opinion.

@lgarron
Copy link
Collaborator

lgarron commented Feb 7, 2019

Thanks, I think this is pretty reasonable!

@ZerooCool
Copy link
Contributor Author

For the button at the bottom, this is better :
Replace max-width: 22em; by max-width: 25em;

Thank you for your validation.

@nharper nharper merged commit 34bf4e3 into chromium:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants