-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print and print preview is not working in iframe window. #2753
Comments
Original comment by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil). I have tested in Google Chrome version 75.0.3770.100, print is working fine in iframe window. |
Original changes by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil).
|
Original changes by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil).
|
1 similar comment
Original changes by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil).
|
Original comment by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil). I have tested in the latest branch 3865 and in Master branch as well, print does not work in iframe content window. |
Original changes by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil).
|
Original comment by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil). I have fixed the issue, will raise a PR after testing. |
Original comment by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil). |
Fix printing from iframes (fixes issue #2753) → <<cset b560f0404603 (bb)>> |
|
Fix printing from iframes (fixes issue #2753) → <<cset 7692d87e04b5 (bb)>> |
Original comment by Ilia Shkolyar (Bitbucket: iliashko, GitHub: iliashko). Hello @{557058:2f2a2aee-b500-4023-9734-037e9897c3ab} , Will this fix be ported into the 3865 branch as well? Thanks |
Original report by Anil Achary (Bitbucket: acharyanil, GitHub: acharyanil).
In cefclient (3770 branch+
1669c0a
commit and in master branch), print and print preview is not working in iframe content window.I have included below iframe in the cefclient
\<div class=&
#34;ctr-p" id="viewport"><div id="doc-info"></div>\<iframe src=&
#34;https://www.google.com" id="testprint"></iframe>and executed below command in console.
document.getElementById(&
#39;testprint').contentWindow.document.execCommand('print');Print dialog does not appear.
Rest of the print (windows.print()) works fine, only problem is in the iframe window.
From the analysis, I have found that CEF is not receiving PrintHostMsg_ShowScriptedPrintPreview (CefPrintViewManager::OnShowScriptedPrintPreview) IPC message when the print is executed in the iframe window.
Tested on windows 10 OS.
Best Regards,
Anil
The text was updated successfully, but these errors were encountered: