Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Commit

Permalink
[writer] fixing date write bug (fixes #29)
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric Gazoni committed Apr 7, 2011
1 parent 98c7922 commit 3389a58
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
20 changes: 20 additions & 0 deletions openpyxl/tests/test_workbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@

# package imports
from openpyxl.workbook import Workbook
from openpyxl.reader.excel import load_workbook
from openpyxl.namedrange import NamedRange
from openpyxl.shared.exc import ReadOnlyWorkbookException
from openpyxl.tests.helper import TMPDIR, clean_tmpdir, make_tmpdir

import datetime

def test_get_active_sheet():
wb = Workbook()
Expand Down Expand Up @@ -126,3 +128,21 @@ def test_add_local_named_range():
wb.add_named_range(named_range)
dest_filename = osp.join(TMPDIR, 'local_named_range_book.xlsx')
wb.save(dest_filename)


@with_setup(setup = make_tmpdir, teardown = clean_tmpdir)
def test_write_regular_date():

today = datetime.datetime(2010, 1, 18, 14, 15, 20, 1600)

book = Workbook()
sheet = book.get_active_sheet()
sheet.cell("A1").value = today
dest_filename = osp.join(TMPDIR, 'local_named_range_book.xlsx')
book.save(dest_filename)

test_book = load_workbook(dest_filename)
test_sheet = test_book.get_active_sheet()

eq_(test_sheet.cell("A1").value, today)

2 changes: 1 addition & 1 deletion openpyxl/writer/worksheet.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def write_worksheet_data(doc, worksheet, string_table, style_table):
row_cells = cells_by_row[row_idx]
sorted_cells = sorted(row_cells, key = row_sort)
for cell in sorted_cells:
value = cell.value
value = cell._value
coordinate = cell.get_coordinate()
attributes = {'r': coordinate}
attributes['t'] = cell.data_type
Expand Down

0 comments on commit 3389a58

Please sign in to comment.