Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover Travis CI references #791

Closed
atouchet opened this issue Aug 25, 2022 · 7 comments
Closed

Leftover Travis CI references #791

atouchet opened this issue Aug 25, 2022 · 7 comments

Comments

@atouchet
Copy link
Contributor

atouchet commented Aug 25, 2022 •
edited
Loading

Travis CI support was removed in #436 but there are still some leftover references remaining in the project.

chrono/Makefile

Line 25 in 3467172

CHANNEL=$(CHANNEL) ./ci/travis.sh

chrono/Cargo.toml

Line 12 in 17d8c2a

exclude = ["/ci/*", "/.travis.yml", "/appveyor.yml", "/Makefile"]

@atouchet atouchet changed the title Leftover Travis CI and AppVeyor references Leftover Travis CI references Aug 25, 2022
@esheppa
Copy link
Collaborator

esheppa commented Aug 26, 2022

Thanks for the report @atouchet - will get this cleaned up along with some other changes in #793

cjrh added a commit to cjrh/chrono that referenced this issue Sep 10, 2022
@cjrh
Remove leftover Travis CI refs. Fixes chronotope#791
9060f5e
cjrh added a commit to cjrh/chrono that referenced this issue Sep 10, 2022
@cjrh
Remove Travis CI references. Fixes chronotope#791
b17bbe7
@cjrh
Copy link

cjrh commented Sep 10, 2022

Since #793 got closed, I've made a new PR #816 containing only these fixes.

@esheppa
Copy link
Collaborator

esheppa commented Sep 10, 2022

Thanks @cjrh - we will likely use #814 to fix this, which includes all changes of your PR, but also removes the shell files used in CI in favour of putting everything in the yaml files.

@cjrh
Copy link

cjrh commented Sep 10, 2022

Ah ok, I didn't know. Should I close my PR then?

@cjrh cjrh mentioned this issue Sep 12, 2022
Closed
@pitdicker
Copy link
Collaborator

I believe these leftover references are all gone now.

@djc djc closed this as completed Jun 6, 2023
@atouchet
Copy link
Contributor Author

atouchet commented Jun 6, 2023 •
edited
Loading

chrono/Makefile

Line 22 in 088b693

CHANNEL=$(CHANNEL) ./ci/travis.sh

This file still references travis.sh.

@pitdicker
Copy link
Collaborator

@atouchet Thank you for looking into it again!
Removed the Makefile in #1133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@djc @cjrh @pitdicker @atouchet @esheppa