-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.60 #1347
Bump MSRV to 1.60 #1347
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1347 +/- ##
==========================================
+ Coverage 91.60% 91.61% +0.01%
==========================================
Files 38 38
Lines 17430 17482 +52
==========================================
+ Hits 15966 16016 +50
- Misses 1464 1466 +2
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry I have been absent, I'll have a look tomorrow. |
@pitdicker no worries! Friendly ping? |
I am trying to understand the cause of the dependency resolution issue on 1.57.0. It seems to be because ahash 0.7.6 is yanked last week. We used to have 0.7.6 in the dependency tree. All versions before 0.7.7 have a vulnerability and are yanked: tkaitchuck/aHash#163, fixed in PR tkaitchuck/aHash#175. Maybe we should get in contact in tkaitchuck/aHash#174 or some other issue before bumping the MSRV? |
I think it's probably because the latest ahash 0.7 release includes use of specific dep: features, which cause Cargo before 1.60 to fail parsing the manifest (but I didn't actually check). |
I feel like it's okay to get to 1.60 at this point. Current Debian stable has 1.63. |
Okay, I'm the last to complain about bumping the MSRV 😄. and Debian is pretty much the one to care about, right? Do you also want to update the documentation in |
If we bump to 1.61 we can start making the methods on |
Added the |
@pitdicker ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, in my memory this was already merged.
Fixes #1344, I think.