Implement find_local_time_type_from_local
#683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on tz-rs commit b8675e2b5794d923f80970daf9ea548cfb998db2, with substantial modifications from me.
esheppa
commented
May 1, 2022
src/offset/local/unix.rs
Outdated
Comment on lines
40
to
45
| let info = unsafe { | ||
| INIT.call_once(|| { | ||
| INFO = Some(TimeZone::local().expect("unable to parse localtime info")); | ||
| }); | ||
| INFO.as_ref().unwrap() | ||
| }; |
There was a problem hiding this comment.
Potentially this caching behavior should be configurable. In a long running application, it might be unexpected that even when the system timezone changes, the application still uses the old timezone
esheppa
force-pushed
the
tz-info-from-local
branch
from
bba17ae
to
fd32afd
Compare
|
Will try to recreate this to get CI running |
This was referenced Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_local_time_type_from_localwhich uses a local instead of UTC timestamp to compare to the transitions and extra rulesLocalResultas far up as possible to ensure that ambiguous and skipped local timestamps are recognizedPotential additions:
try_from_local_datetimein theTimeZonetrait which returns aLocalResultallowing users of the library to handle ambiguous or skipped timestamps and avoid panics.