-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint actions. #195
Add lint actions. #195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 77 77
Lines 6223 6223
Branches 520 520
=======================================
Hits 5405 5405
Misses 298 298
Partials 520 520 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @niyarin!! Thank you for the PR 👍
.github/workflows/lint.yml
Outdated
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
runner: ":leiningen" | ||
usefiles: "true" | ||
files: ${{ steps.git_diff.outputs.diff }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done without using technote-space/get-diff-action
?
I want to have fewer dependencies on unofficial GitHub actions.
Thank you for pointing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks!!
Thank you for the reviewing. |
I added lint action.
The "clj-lint action" is added to the first of some actions (coverage, format, int, main).