Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint actions. #195

Merged
merged 2 commits into from May 18, 2020
Merged

Add lint actions. #195

merged 2 commits into from May 18, 2020

Conversation

niyarin
Copy link
Contributor

@niyarin niyarin commented May 7, 2020

I added lint action.
The "clj-lint action" is added to the first of some actions (coverage, format, int, main).

@niyarin niyarin requested review from alumi and a team as code owners May 7, 2020 06:13
@niyarin niyarin requested review from athos and removed request for a team May 7, 2020 06:13
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          77       77           
  Lines        6223     6223           
  Branches      520      520           
=======================================
  Hits         5405     5405           
  Misses        298      298           
  Partials      520      520           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c479aae...4231029. Read the comment docs.

Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niyarin!! Thank you for the PR 👍

github_token: ${{ secrets.GITHUB_TOKEN }}
runner: ":leiningen"
usefiles: "true"
files: ${{ steps.git_diff.outputs.diff }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be done without using technote-space/get-diff-action?
I want to have fewer dependencies on unofficial GitHub actions.

.github/workflows/lint.yml Show resolved Hide resolved
@niyarin
Copy link
Contributor Author

niyarin commented May 16, 2020

Thank you for pointing.
I add calculating diff files and eastwood linter option to xcoo/clj-lint-action.

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!!

@alumi alumi merged commit 81f05ee into master May 18, 2020
@alumi alumi deleted the feature/lint-action branch May 18, 2020 02:52
@niyarin
Copy link
Contributor Author

niyarin commented May 18, 2020

Thank you for the reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants