-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate fusion genes #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 43.49% 45.24% +1.75%
==========================================
Files 15 16 +1
Lines 1805 1954 +149
Branches 39 61 +22
==========================================
+ Hits 785 884 +99
- Misses 981 1009 +28
- Partials 39 61 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great feature. The implementation looks good to me. I have left a few trivial comments.
@@ -24,7 +24,8 @@ | |||
:1.8 {:dependencies [[org.clojure/clojure "1.8.0"] | |||
[clojure-future-spec "1.9.0"]]} | |||
:1.9 {:dependencies [[org.clojure/clojure "1.9.0"]]} | |||
:1.10 {:dependencies [[org.clojure/clojure "1.10.3"]]}} | |||
:1.10 {:dependencies [[org.clojure/clojure "1.10.3"]]} | |||
:1.11 {:dependencies [[org.clojure/clojure "1.11.1"]]}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 1.11
to also .github/workflows/build.yml
.
varity/.github/workflows/build.yml
Line 11 in f84c720
clojure: ['1.8', '1.9', '1.10'] |
README.md
Outdated
@@ -130,3 +130,7 @@ To convert a genomic coordinate between assemblies, | |||
Copyright 2017-2021 [Xcoo, Inc.](https://xcoo.jp/) | |||
|
|||
Licensed under the [Apache License, Version 2.0](LICENSE). | |||
|
|||
## Acknowledgement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prural Acknowledgements
generally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speedy. Thank you.
This PR adds a new namespace
varity.fusion
to annotate fusion genes for breakpoints.varity.fusion
assumes a variant in the format of VCF as an input.varity.fusion/variant->breakpoints
converts a variant into an breakpoint entry.varity/src/varity/fusion.clj
Lines 229 to 231 in 12c1026
Then,
varity.fusion/fusion-transcripts
annotates fusion transcripts for the breakpoint.This is a function intended for ease of use and is just a simple combination of the following 3 functions.
varity/src/varity/fusion.clj
Lines 194 to 196 in 12c1026
varity.fusion/fusion-genes
searches for all possible gene pairs from refGene and determines if each pair can form a valid fusion transcript.varity/src/varity/fusion.clj
Lines 151 to 160 in 12c1026
varity.fusion/in-frame?
checks if a fused sequence is aligned in or out of reading frame.varity/src/varity/fusion.clj
Line 175 in 12c1026
varity.fusion/transcript
gives an amino acid sequence for a fusion gene.varity/src/varity/fusion.clj
Line 186 in 12c1026
The annotation algorithm is originally developed at Cancer Precision Medicine Center, Japanese Foundation for Cancer Research and I re-implemented it with some additional features such as:
Thankfully, @athos, @r6eve and @k-kom have already reviewed this PR internally.