Incorrect translation for unaffected stop codon #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 46.45% 46.49% +0.03%
==========================================
Files 16 16
Lines 2090 2095 +5
Branches 70 70
==========================================
+ Hits 971 974 +3
- Misses 1049 1051 +2
Partials 70 70 ☔ View full report in Codecov by Sentry. |
nokara26
commented
Jan 15, 2024
Comment on lines
+434
to
+437
| [ppos pref palt {:keys [ref-prot-seq alt-prot-seq alt-tx-prot-seq c-ter-adjusted-alt-prot-seq ini-offset]}] | ||
| (if (and (not= ppos 1) | ||
| (ter-site-same-pos? ref-prot-seq c-ter-adjusted-alt-prot-seq)) | ||
| (mut/protein-no-effect) |
There was a problem hiding this comment.
In this function, I added line 435-437 and moved seq-info destructuring to args .
And I just fixed indent of following lines.
federkasten
approved these changes
Jan 15, 2024
nokara26
force-pushed
the
fix/add-ter-site-no-effect-condition
branch
from
f8178d1
to
1a892fe
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #83
I added conditional branch that ter-site position is not changed to extension.