Basic command line options enhancement #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,8 @@ CTOP is a tool which allows you to quickly find out what's happening on a machin | |||
| * Metrics are for one node only (not cluster-wide) | |||
|
|
|||
| ## Notes | |||
| * CTOP should run on anything, but I've only tested it on Ubuntu. | |||
| * CTOP should run on anything. Originally was developed on Ubuntu, runs | |||
| great on CentOS and MacOS X. | |||
There was a problem hiding this comment.
Can we change this to: "Originally was developed on Ubuntu, and it's reported to run on CentOS and MacOS X"?
Great is relative 8)
|
I am not familiar MX4J so I don't know how correct is the option name change. Otherwise it looks good to me 👍 cc @chrusty |
|
The suggested changes look fine to me, but I'd like to keep the port called "MX4JPort" rather than "cassandraPort", because this port is opened by the MX4J plugin rather than by cassandra itself. This should remind people that they need to be running Cassandra with MX4J if they find that it doesn't work. The rest of the stuff looks good though. |
chrusty
added a commit
that referenced
this pull request
Mar 30, 2015
Basic command line options enhancement
|
@chrusty thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--portoption