protocol.py: Take block1.size_exponent from option if it exists #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a CoAP client to set the transfer block size doing something like: msg.opt.block1 = (0, True, 2), where 2 is the size_exponent, which will result in 64 byte block size. Signed-off-by: Nenad Ilic <nenadilic84@gmail.com>
|
@chrysn, I opened this PR as I was having issue setting the block size. If you think this can be solved some other way, let me know. |
|
Thanks, this looks useful as it provides the sender to explicitly set a per-messge size; for the general request of having a generically configurable default size, it provides a workaround. I've added an additional check that no non-zero block offsets could be injected via that; it could still be supported, but right now it's a potential cause of confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a CoAP client to set the transfer block size doing
something like: msg.opt.block1 = (0, True, 2), where 2 is the
size_exponent, which will result in 64 byte block size.
Signed-off-by: Nenad Ilic nenadilic84@gmail.com