Implement interactive mode #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because getTerminalSize from ansi-terminal expects not only stdout, but also stdin to be a terminal, which is too restrictive.
chshersh
added
the
hacktoberfest-accepted
chshersh
reviewed
Oct 18, 2022
src/DrCabal/Interactive.hs
Outdated
Comment on lines
5
to
6
| Copyright : (c) 2019 Alexander Gugel | ||
| (c) 2022 Dmitrii Kovanikov |
There was a problem hiding this comment.
I have no complaints on the current copyright, you can even put your name here if you want 🙂
But I'm curious about the original code 🤔 Where a similar code was already written?
There was a problem hiding this comment.
My bad, I just copied header from DrCabal.Watch.
src/DrCabal/Interactive.hs
Outdated
Comment on lines
70
to
74
| -- https://github.com/UnkindPartition/ansi-terminal/issues/141 | ||
| when (chartHeight > 0) $ | ||
| cursorUp chartHeight | ||
| setCursorColumn 0 | ||
| clearFromCursorToScreenEnd |
There was a problem hiding this comment.
Let's move this into a separate function clearScreen or something like that for readability.
chshersh
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28.