Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City's which share names causes location to not be correct #209

Closed
fxdgear opened this issue Jul 10, 2018 · 6 comments
Closed

City's which share names causes location to not be correct #209

fxdgear opened this issue Jul 10, 2018 · 6 comments

Comments

@fxdgear
Copy link

fxdgear commented Jul 10, 2018

From the comment here: https://theptrk.com/2018/07/08/weather-reports-with-curl/#comment-96

the author is saying that the location comes from the IP address (which makes sense).

navigating to that url I can see that my City and State are properly located.

But wttr.in when it gets the location information just uses the City Name in it's look up and as a result it's locating me in a different country where the city name is the same.

@chubin
Copy link
Owner

chubin commented Oct 26, 2018

The problem is fixed now (I hope). Please check if it works for you.
And thank you for reporting

@chubin chubin closed this as completed Oct 26, 2018
@fxdgear
Copy link
Author

fxdgear commented Oct 26, 2018

I just checked and it’s still pulling up a city Australia and I live in the USA.

@chubin
Copy link
Owner

chubin commented Oct 26, 2018

@fxdgear Thank you for testing. What IP (please obfuscate the IP a little) it was?

@fxdgear
Copy link
Author

fxdgear commented Oct 26, 2018

Try this one: 72.42.83.79 it seems to be geolocating to the same spot via https://www.iplocation.net/

the city name that's the issue is Pine Grove

@chubin chubin reopened this Oct 26, 2018
@chubin
Copy link
Owner

chubin commented Oct 26, 2018

I suppose that I've localized and fixed the bug. It should work now. Please test.
Your case was a really tricky one

@chubin chubin closed this as completed in dbb8aab Oct 26, 2018
@fxdgear
Copy link
Author

fxdgear commented Oct 26, 2018

better!! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants