Support older Android API versions #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chvp
force-pushed
the
feat/old-android-api
branch
from
c034143
to
85ffca1
Compare
chvp
force-pushed
the
feat/old-android-api
branch
from
913bb9e
to
9544cb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main things prevented us from using old API versions:
The API version we changed to is the absolute lowest we will ever be able to go; Jetpack Compose doesn't support API versions below 21, and removing the usage of compose would require a full rewrite of the app, which I would definitely not be willing to do.
Fixes #95.