Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.0 getAuthorizeUrl() type=web_server is depricated #127

Closed
bendiy opened this issue Feb 28, 2013 · 0 comments · Fixed by #154 or bradgignac/node-oauth#1
Closed

OAuth 2.0 getAuthorizeUrl() type=web_server is depricated #127

bendiy opened this issue Feb 28, 2013 · 0 comments · Fixed by #154 or bradgignac/node-oauth#1

Comments

@bendiy
Copy link

bendiy commented Feb 28, 2013

You're adding "type=web_server" to the authorize URL and it does not need to be there:
https://github.com/ciaranj/node-oauth/blob/master/lib/oauth2.js#L126

It appears that was part up OAuth2.0 drafts up to version 7:
http://tools.ietf.org/html/draft-ietf-oauth-v2-07#section-4.1.1

And removed in version 8:
http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1

bradgignac pushed a commit to bradgignac/node-oauth that referenced this issue Jul 27, 2013
While the type parameter was required in older versions of the OAuth2
specification, it was removed in version 8. Currently, this breaks OAuth2
against the Dropbox API. Closes issue ciaranj#127.

http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1
bradgignac pushed a commit to bradgignac/node-oauth that referenced this issue Jul 27, 2013
While the type parameter was required in older versions of the OAuth2
specification, it was removed in version 8. Currently, this breaks OAuth2
against the Dropbox API. Closes ciaranj#127.

http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant