OAuth 2.0 getAuthorizeUrl() type=web_server is depricated #127

Closed
bendiy opened this Issue Feb 28, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@bendiy

bendiy commented Feb 28, 2013

You're adding "type=web_server" to the authorize URL and it does not need to be there:
https://github.com/ciaranj/node-oauth/blob/master/lib/oauth2.js#L126

It appears that was part up OAuth2.0 drafts up to version 7:
http://tools.ietf.org/html/draft-ietf-oauth-v2-07#section-4.1.1

And removed in version 8:
http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1

bradgignac added a commit to bradgignac/node-oauth that referenced this issue Jul 27, 2013

Remove type query parameter from OAuth2 requests.
While the type parameter was required in older versions of the OAuth2
specification, it was removed in version 8. Currently, this breaks OAuth2
against the Dropbox API. Closes issue #127.

http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1

bradgignac added a commit to bradgignac/node-oauth that referenced this issue Jul 27, 2013

Remove type query parameter from OAuth2 requests.
While the type parameter was required in older versions of the OAuth2
specification, it was removed in version 8. Currently, this breaks OAuth2
against the Dropbox API. Closes #127.

http://tools.ietf.org/html/draft-ietf-oauth-v2-08#section-4.1.1

@ciaranj ciaranj closed this in #154 Jan 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment