Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to use https proxy agent, when https_proxy env variable is set. #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gstroup
Copy link

@gstroup gstroup commented Apr 8, 2016

No description provided.

@binario200
Copy link

I have dealing with proxy issues at my job. I found a similar solution. Where this will be merge?

@mookkiah
Copy link

As many corporate infrastructure has http proxy in place, it is good idea to honor these environment variables NO_PROXY, HTTPS_PROXY, HTTP_PROXY, http_proxy, https_proxy, no_proxy

Is the merge conflict a reason for not getting this PR merged? If yes, I am happy to help resolving and considering all the above variables covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants