Acceptance test tentative API #38
Conversation
|
@machty You might also be interested. |
| @@ -1,7 +1,7 @@ | |||
| module.exports = { | |||
| root: true, | |||
| parserOptions: { | |||
| ecmaVersion: 6, | |||
| ecmaVersion: 2017, | |||
|
|
||
| moduleForAcceptance('Acceptance | usage in acceptance'); | ||
|
|
||
| test('Usage awaiting the world to settle', async function(assert) { |
There was a problem hiding this comment.
Does the use of async / await require changes in the build, e.g. babel config?
There was a problem hiding this comment.
No, babel 6 will know what to transpile automatically based on the browsers you support.
There was a problem hiding this comment.
Let me amend that thing above.
In order for async/await to work you have to have the regenerator runtime (via ember-maybe-import-regenerator), include the babel polyfill or use the new targets feature (https://github.com/ember-cli/rfcs/blob/master/complete/0095-standardise-targets.md) in ember-cli 2.13 and only support browsers with async/await.
| @@ -1,20 +1,20 @@ | |||
| <h1>Signup example</h1> | |||
|
|
|||
| <form {{action "signup" on="submit"}}> | |||
| <form class="signup-example-form" {{action "signup" on="submit"}}> | |||
There was a problem hiding this comment.
We have an example form component used for component tests. Would it be feasible to combine the two use cases, e.g. test a form component via integration test and use the same form component in the app for an acceptance test?
There was a problem hiding this comment.
Not sure if I follow. The helpers will be the same, with the exception that some of them, like visit should probably raise an error if used in integration
There was a problem hiding this comment.
I'm referring to the dummy/app/component that we could also use for both testing in integration and acceptance.
- https://github.com/cibernox/ember-native-dom-helpers/blob/master/tests/integration/components/x-form-test.js
- https://github.com/cibernox/ember-native-dom-helpers/blob/master/tests/dummy/app/templates/components/x-form.hbs
- https://github.com/cibernox/ember-native-dom-helpers/blob/master/tests/dummy/app/components/x-form.js
There was a problem hiding this comment.
Ah, I see. I didn't consider it. I wanted to create an example with async behaviour (loading substate, disable a button while a request is ongoing...) that is hard to test currently to prove that this approach would allow it.
I think that we can keep them separated.
| @@ -0,0 +1,33 @@ | |||
| import { test } from 'qunit'; | |||
| import moduleForAcceptance from '../../tests/helpers/module-for-acceptance'; | |||
| import { visit, click, fillIn, waitUntil } from 'ember-native-dom-helpers/test-support/helpers'; | |||
There was a problem hiding this comment.
Do we need to do anything special as we're masking the global helpers here?
There was a problem hiding this comment.
This approach masks the global helpers, although they would be reachable using window
There was a problem hiding this comment.
Yeah I know we're masking intentionally but I generally think it's not the best example to show off something. I get that we may need to do that. I wonder if a comment that says "We're masking the global helpers here, they are still available, e.g use window.find"
There was a problem hiding this comment.
Yes, that should be documented, although my intention with this PR is bring attention over how this syntax and approach feels.
@machty p.e suggested making find/findAll async, and accept modifiers like find('.some-class', { count: 5 }). I then suggested the existence of the waitUntil helper and keep finders sync. That kind of feedback.
|
@cibernox - Looks good. I think the initial API for export default function visit() {
if (!window.visit) {
throw new Error('visit is only available during acceptance tests');
}
return window.visit(...arguments);
} |
This PR is opened with a failing test that demonstrates the tentative API for acceptance test, including an example of asserting transient loading substates.
cibernox
force-pushed
the
make-it-work-in-acceptance
branch
from
3a3363a
to
a547c0b
Compare
|
@rwjblue I've implemented the The acceptance test that I wrote initially now is green (yay TDD!) and I added tests for the helper in integration. |
This PR is opened with a failing test that demonstrates the tentative API
for acceptance test, including an example of asserting transient loading
substates.