-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember 3.17 : error in animateOut #1338
Comments
settings animationEnabled to false does nothing as // CPs
get animationEnabled() {
if (this._animationEnabled) {
return this._animationEnabled;
}
let config = Ember.getOwner(this).resolveRegistration('config:environment');
return config.environment !== 'test';
} this return true |
Hello! |
no error in the test because animationEnabled is false for test environment |
Same here with v3.17 |
Same here ember v3.17 |
Same here with 3.17 as well |
Same here with 3.17. |
shouldn't be enabled in tests too? This error was silently deployed in production even with a high test coverage 😢 |
Same here with Ember 3.17 and EPS 3.0.6 Any plans to fix this in EPS 3.x.x (or EBD 2.x.x)? |
I got rid of these errors by updating to https://github.com/cibernox/ember-power-select/releases/tag/v4.0.0-beta.6 |
@leondmello yeah as i said it got tackled in ember basic dropdown 3, which is the one EPS 4-beta is using. The problem is im using different addons which rely on EBD 2. |
Yes, I wrote the suggestion for all the other people for whom it might get fixed by updating to the BETA. |
I plan to make the beta final today, after I merge a couple PRs. Hopefully that will invite people using ember octane to update |
updated all the dependencies today already to ebd 3 and eps 4-beta. glad i moved partially already to octane, seems to continue working like before! |
I released 4.0.0 final, so everyone having problems in the very latest version of Ember should be able to update and have them fixed. There is barely any breaking changes, the component uses octane idioms, glimmer components, typescript, @Tracked and all that jazz. |
I think this can be closed now, this is fixed in 4.0.0 |
closes TryGhost/Ghost#11685 - `ember-source` 3.17.x has an incompatibility with `ember-power-select` - see cibernox/ember-power-select#1338 - add `ember-source` to renovate ignore list to avoid unintentional bumps
ember-power-select-with-create depends on ember-power-select 3.x which gives an error in Ember v3.17. See cibernox/ember-power-select#1338
Hello,
When I update to 3.17. i got a parentElement undefined in
I use ember-bootstrap-power-select so i don't know yet which one is responsible
The text was updated successfully, but these errors were encountered: