Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid character error only in IE browser and only for production environment #915

Closed
kumkanillam opened this issue May 25, 2017 · 2 comments

Comments

@kumkanillam
Copy link

Due to some newer feature usage(I am not sure is it in my app folder or from addon) in my project, uglify.js is not working for minification, so I uninstalled ember-cli-uglify and included ember-cli-babili reference (http://rwjblue.com/2017/04/21/ember-cli-targets/).

Here comes the issue,
In group-utils.js file,there is const DIACRITICS = { 'A':'A' } 840 characters defined here .
In develpment environment,its working fine since key is in single quotes const DIACRITICS = { 'A':'A' }
In production environment, it's minified as const DIACRITICS = { A:'A' }. this throws Invalid character error in IE-11 browser.

@cibernox
Copy link
Owner

Interesting. A new way Internet Explorer breaks the web. Yay!

I supposed that we can replace the non-utf8 chars by their escaped versions and babili will work. Let me see if I can find the source from where I took this initially.

cibernox added a commit that referenced this issue May 25, 2017
@kumkanillam
Copy link
Author

There is issue with PR already is in the progress in babili project. Fix removal of quotes from property names . Thank you so much for your time :-) Thank you for this Power Packed Addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants