Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to highlight an object option without use the same reference #1637

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

rogeraraujo90
Copy link

Fixes: #1629

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 11, 2024

Thank you!

@mkszepp mkszepp merged commit ea6c0c1 into cibernox:master Jan 11, 2024
19 checks passed
@rogeraraujo90
Copy link
Author

Thank you!

Hi! Can we have a beta tag with this commit? In addition, can you anticipate to me how the styles should be imported in v8? Thanks!

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 18, 2024

@rogeraraujo90 yes i will release everything today in the next beta.

For importing styles in v8 see Documentation -> Installation -> Manual installation https://ember-power-select.com/docs/installation

If something is unclear let me know. In V8 you need also to add <BasicDropdownWormhole /> in application.hbs (everything is listed in docs).

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 18, 2024

@rogeraraujo90 released in 8.0.0-beta.5

@rogeraraujo90
Copy link
Author

@rogeraraujo90 released in 8.0.0-beta.5

Thanks a lot! 🙂

@rogeraraujo90
Copy link
Author

@rogeraraujo90 yes i will release everything today in the next beta.

For importing styles in v8 see Documentation -> Installation -> Manual installation https://ember-power-select.com/docs/installation

If something is unclear let me know. In V8 you need also to add <BasicDropdownWormhole /> in application.hbs (everything is listed in docs).

My project uses ember-cli-sass. Add @import 'ember-power-dropdown'; in app.scss breaks the App on v8 (it was working on v7). But looks like the styles are working without the import so all good. The cons is that I cannot reuse exported variables from styles now.

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 20, 2024

@rogeraraujo90 ups its a docs bug... 'ember-power-select' is correct... i will fix it... thank for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to highlight a specific object option
2 participants