fix: Type error: (n.selected || []).slice is not a function in multiple select
#1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue popping up in sentry, `Type error: (n.selected || []).slice is not a function` on
```ts
defaultBuildSelection(option: any, select: Select) {
const newSelection = (select.selected || []).slice(0);
````
This fix checks for Array.isArray(select.selected) in runtime ( which should not hurt), but e should probably also fix this by narrowing the type of Select.selected – possibly as a generic of what you pass in to options.
mkszepp
changed the title
Type error: (n.selected || []).slice is not a function in multiple select
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue popping up in sentry,
Type error: (n.selected || []).slice is not a functionhere:The proposed fix checks for
Array.isArray(select.selected)in runtime (which should not hurt), but we should probably also fix this by narrowing the type of Select.selected – possibly as a generic of what you pass in to options.