Fix BeforeOptions search input having invalid aria-activedescendant when no results are found
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no search results (hence no highlighted index) we don't expose value for `aria-active-descendant` (we currently show a truncated, invalid value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If there are no search results (hence no highlighted index) we currently show a truncated, invalid value for
aria-activedescendant(for instanceember74-). In this PR we propose to only expose a value foraria-active-descendantif there are results.Example
The example below uses the
helpers-testing-single-power-selectinstance in thetest-app.Automated accessibility checks using axe
Motivation
At @hashicorp we use
<PowerSelect>extensively and we are grateful to see the many improvements introduced lately.This change is primarily motivated by the desire to further improve the accessibility compliance of this component – in this instance, by providing a valid value for
aria-active-descendant.