Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ember-modifier instead of @ember/render-modifiers #1801

Merged
merged 2 commits into from
May 6, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented May 6, 2024

This PR removes all usages from @ember/render-modifiers.

@ember/render-modifiers were meant as a transitional tool from the pre-Octane era, and not long-term usage.

See: https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-at-ember-render-modifiers.md

This changes are not braking.

For apps, which have called our old actions in there custom components, there were added deprecation warnings with notes how they must replace until v9

@mkszepp mkszepp merged commit 45fdb82 into master May 6, 2024
15 checks passed
@mkszepp mkszepp deleted the replace-render-modifiers-with-ember-modifier branch May 6, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant