[BREAKING] Use aria attributes instead of classes for options. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Warning**. Classes ending in `--disabled`, `--highlighted` and `--selected` have been replaced by aria attributes `[aria-disabled="true"]`, `[aria-current="true"]` and `[aria-selected="true"]` respectively. Those attributes are needed for a11y and the recomendation is to style based on them instead of classes. Styles have been updated accordingly, so people using them and customizing the appearance using the sass variables won't notice anything, but people that relied on those classes for overriding styles will have to update them.
cibernox
added a commit
that referenced
this pull request
Feb 5, 2016
…favour_of_aria_attributes [BREAKING] Use aria attributes instead of classes for options.
cibernox
deleted the
ditch_options_BEM_modifiers_in_favour_of_aria_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning.
Classes ending in
--disabled,--highlightedand--selectedhave beenreplaced by aria attributes
[aria-disabled="true"],[aria-current="true"]and[aria-selected="true"]respectively. Those attributes are needed for a11y and the recomendation is to style based on them
instead of classes.
Styles have been updated accordingly, so people using them and customizing the appearance using the
sass variables won't notice anything, but people that relied on those classes for overriding styles
will have to update them.