-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass WAI-ARIA states into dropdown #433
Pass WAI-ARIA states into dropdown #433
Conversation
@@ -67,7 +67,6 @@ | |||
"ember-cli-babel": "^5.1.5", | |||
"ember-cli-htmlbars": "^1.0.1", | |||
"ember-basic-dropdown": "^0.9.5-beta.10", | |||
"ember-hash-helper-polyfill": "^0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that I not longer need this polyfill, but it concerns me that this test is not failing in 1.13 in travis.
Nothing for your to change, just a note to myself.
I don't mind the alphabetically order. I started grouping properties "conceptually", but clearly there was a moment where that stopped scaling 😅 . This is better now. This does need tests tho (and probably some work in ember-basic-dropdown itself). |
Tests in ember-basic-dropdown and ember-power-select overlap a bit, but I try to have tests in EPS for behaviours that are anyway tested in EBD because sometimes they depend of EPS forwarding the proper properties, so in this case the duplication has a purpose. |
I've ended up duplicating in similar ways (and for similar reasons) in the widget set I'm making at work. It's helped to catch refactoring problems when I thought I was safely changing something isolated in one component...and it ends up I was wrong! Especially considering the case of integration tests, in my opinion, it's well worth having all the relevant tests for the EPS interface in the EPS repo...even if it means tests aren't technically as DRY as they could possibly be. |
Tests added. I went ahead and put in tests for |
@jmacqueen mmm... why travis is not running for the last commit? Also, should we update ember-basic-dropdown first? |
Rebase over master to get the version of EPS with support for aria-label. |
5bac03f
to
efab2d5
Compare
Thanks for all the a11y work. This starts to look complete. |
This will pass the following WAI-ARIA relationship and widget attributes through to
basic-dropdown
in an attempt to complete #293I have a thing about alphabetizing long property lists to help out when exploring or debugging, I hope that doesn't cause too much trouble. Other than alphabetizing, these are the only actual additions to the templates.
power-select
attributeariaDescribedBy
aria-describedby
ariaInvalid
aria-invalid
ariaLabel
aria-label
basic-dropdown
, but inclusion here ahead of time doesn't break anythingariaLabelledBy
aria-labelledby
required
aria-required
I didn't include tests because I'm a bad person. And I didn't want to take the time on the off-chance these changes don't go in 😄