Skip to content

Commit

Permalink
rm fof and moira libraries because of their dependency on Osicat
Browse files Browse the repository at this point in the history
which depends on its libosicat.so, which makes it more difficult to
deploy executables.
This dependency might be fixed upstream, check out the linked issues.
  • Loading branch information
vindarel committed Nov 18, 2023
1 parent f8eb032 commit 56d3d1f
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 7 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ So, save you some typing with a shell alias:

## Scripting

NOTE: this is brand new! Expect limitations and changes.
> [!NOTE]
> this is brand new! Expect limitations and changes.
Get the `ciel` binary and call it with your .lisp script:

Expand Down
14 changes: 12 additions & 2 deletions ciel.asd
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,22 @@
:access
:alexandria
:arrow-macros
:fof ;; file-object-finder

;; Those are two dependencies that we like,
;; but that depend on osicat, hence complicate deployment of binaries.
;; check with (ql:who-depends-on "osicat")
;; Maybe create a sub-system with them.
;;
;; :fof ;; concise file-object finder.
;; :moira ;; monitor and restart background threads.
;;
;; see
;; https://gitlab.com/ambrevar/fof/-/issues/6
;; https://github.com/ruricolist/moira/issues/1

;; threads
:bordeaux-threads
:trivial-monitored-thread
:moira
:lparallel
:cl-cron

Expand Down
6 changes: 4 additions & 2 deletions docs/dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ variables and and function return values.
- easy-routes: Yet another routes handling utility on top of Hunchentoot
- fiveam: A simple regression testing framework
- fn: Some macros for lambda brevity
- fof: File-object finder. Enable rapid file search, inspection and manipulation.
<!-- currently removed: -->
<!-- - fof: File-object finder. Enable rapid file search, inspection and manipulation. -->
- for: An extensible iteration macro library.
- fset: A functional set-theoretic collections library.
See: http://www.ergy.com/FSet.html
Expand All @@ -42,7 +43,8 @@ See: http://www.ergy.com/FSet.html
- nodgui: Tck-Tk graphical user interfaces. nodgui is a fork of Ltk with a built-in theme and more widgets.
- metabang-bind: Bind is a macro that generalizes multiple-value-bind, let, let*, destructuring-bind, structure and slot accessors, and a whole lot more.
- modf: A SETF like macro for functional programming
- moira: Monitor and restart background threads.
<!-- currently removed: -->
<!-- - moira: Monitor and restart background threads. -->
- named-readtables: Library that creates a namespace for readtables akin
to the namespace of packages.
- parse-float: Parse floating point values in strings.
Expand Down
7 changes: 5 additions & 2 deletions docs/libraries.md
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ filesystem:truenamize
filesystem:with-current-directory
```

We include the [FOF (File-object finder)](https://gitlab.com/ambrevar/fof/) library, which is very useful to:
We'd like to mention the [FOF (File-object finder)](https://gitlab.com/ambrevar/fof/) library, which is very useful to:

- search for files, recursively or not, and filter with our predicates,
- inspect the file objects with the regular `inspect` or `describe`
Expand All @@ -512,6 +512,8 @@ In practice, it mostly supersedes:
Note that FOF is not meant to manipulate arbitrary paths of non-existing files.
Consider using [ppath](https://github.com/fourier/ppath) instead.

> Note: `fof` isn't shipped by default in CIEL anymore since 2023, Nov 18th, you should `quickload`. While still useful, it complicates a little bit the deployment of executables because of its dependency on Osicat, which depends on its own `libosicat.so` shared library.
Quick examples:

~~~lisp
Expand Down Expand Up @@ -773,7 +775,8 @@ We ship:

[Lparallel](https://lparallel.org/)

[Moira](https://github.com/ruricolist/moira) (monitor and restart background threads)
<!-- currently removed: <2023-11-18 Sat> see .asd -->
<!-- [Moira](https://github.com/ruricolist/moira) (monitor and restart background threads) -->

[trivial-monitored-thread](http://quickdocs.org/trivial-monitored-thread/)

Expand Down

0 comments on commit 56d3d1f

Please sign in to comment.