Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ember CLI 2.15.1 #143

Merged
merged 19 commits into from
Sep 27, 2017
Merged

Upgrade to Ember CLI 2.15.1 #143

merged 19 commits into from
Sep 27, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Sep 22, 2017 •
edited
Loading

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Updated to Ember CLI version 2.15.1 (uses babel 6)
  • Updated imports to ember javascript modules syntax
  • Added eslint rule to require usage of new modules syntax (will remove once added to ember-test-utils)
  • Updated test helpers to now come from addon-test-support
  • Updated ember-cli-code-coverage and configured reporters
  • Removed ember-string-ishtmlsafe-polyfill - If running Ember CLI < 2.8 then add back to your consuming addon/app.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling e0fb67c on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d260584 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling d8e3a32 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff6e5d2 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ccf8844 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@krasnoukhov krasnoukhov mentioned this pull request Sep 22, 2017
Closed
4 tasks
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0968037 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b584b00 on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 21a78bf on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6e7a83e on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3aead5a on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6bb798f on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4d153ab on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

notmessenger
notmessenger approved these changes Sep 27, 2017
View reviewed changes
addon/mixins/prop-types.js Outdated
const {Mixin, assign, get, getWithDefault, merge, typeOf} = Ember
import {get, getWithDefault} from '@ember/object'
import Mixin from '@ember/object/mixin'
import {assign, merge} from '@ember/polyfills' // eslint-disable-line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming // eslint-disable-line is needed, but why so?

Copy link
Contributor Author

@juwara0 juwara0 Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was put there by the codemod. I removed it and ran our linting and did not get an error. It has now been removed.

@notmessenger
Copy link
Contributor

notmessenger commented Sep 27, 2017 •
edited by cstolli
Loading

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d0964ca on juwara0:upgradeEmberCli_2-15-1 into ** on ciena-blueplanet:master**.

@juwara0 juwara0 merged commit b22dc82 into ciena-blueplanet:master Sep 27, 2017
@juwara0 juwara0 deleted the upgradeEmberCli_2-15-1 branch September 27, 2017 13:08
@juwara0 juwara0 mentioned this pull request Sep 27, 2017
Closed
notmessenger added a commit to notmessenger/ember-prop-types that referenced this pull request Nov 2, 2017
@notmessenger
Revert "Merge pull request ciena-blueplanet#143 from juwara0/upgradeE…
20f32e7 
…mberCli_2-15-1"

This reverts commit b22dc82, reversing
changes made to 8597b40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger notmessenger approved these changes

Assignees

@notmessenger notmessenger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juwara0 @coveralls @notmessenger