Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of API and Codebase #150

Merged
merged 110 commits into from
Aug 19, 2016
Merged

Conversation

sandersky
Copy link
Contributor

@sandersky sandersky commented Jul 20, 2016

MAJOR

Resolves #8
Resolves #119
Resolves #120
Resolves #121
Resolves #161

CHANGELOG

Breaking

  • Moved non-Ember specific code to bunsen-core and started consuming via ember-bunsen-core.
  • Removed following properties from frost-bunsen-form component: cancelLabel, inline, onCancel, onSubmit, and submitLabel.
  • Removed z-schema bower dependency in favor of using ember-z-schema.
  • Removed frost-bunsen-container, frost-bunsen-model-container, and frost-bunsen-row components as they are no longer necessary to support schema.
  • Updated CSS to no longer provide .inline and .not-inline classes for forms and just made previous .inline styles the default without the extra .inline class name.
  • Updated dependencies to latest versions.
  • Updated internal components to work with view schema version 2.
  • Updated internal store to use immutable for the forms value. See seamless-immutable for more.
  • Simplified the DOM being rendered by the components to reduce the DOM footprint and make the styles less complex.

Non-Breaking

  • Added a new url renderer.
  • Added a ton of integration tests to help prevent any future regressions.
  • Fixed button-group renderer to support disabled state.
  • Fixed CI build for EMBER_TRY_SCENARIO=ember-beta.
  • Fixed false positive ember-prop-type warnings by using hasRegistration() instead of lookup().
  • Fixed multi-select renderer documentation to provide working example.
  • Fixed array add and remove buttons to become disabled when appropriate.
  • Fixed issue with changing model not revalidating.
  • Fixed array autoAdd feature to work with non-object arrays.
  • Fixed property-chooser and multi-select renderers to implement placeholder view property.
  • Fixed property-chooser to properly implement label property.
  • Drastically improved demo.

@sandersky sandersky changed the title DO NOT MERGE Simplification of API and Codebase Simplification of API and Codebase Aug 19, 2016
@coveralls
Copy link

coveralls commented Aug 19, 2016

Coverage Status

Changes Unknown when pulling 3f50cb4 on sandersky:master into * on ciena-frost:master*.

@cstolli
Copy link
Contributor

cstolli commented Aug 19, 2016

👍

Approved with PullApprove

@cstolli cstolli merged commit a97f571 into ciena-frost:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants