Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array should provide customizable Add button text, as acronyms are incorrectly translated #507

Merged
merged 5 commits into from
Feb 2, 2018
Merged

Array should provide customizable Add button text, as acronyms are incorrectly translated #507

merged 5 commits into from
Feb 2, 2018

Conversation

notmessenger
Copy link
Contributor

@notmessenger notmessenger commented Feb 1, 2018 •
edited
Loading

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Closes #506

CHANGELOG

  • Section heading text now respects the label property. When set it will return the value of the property with the first character capitalized, whereas before it would use the exact value provided.
  • "Add" button in the array container now respects the label property. When set it will return a singularized version of the text without affecting the case, whereas before it would lowercase the text.

@juwara0
Copy link
Contributor

juwara0 commented Feb 1, 2018 •
edited by cstolli
Loading

👍

Approved with PullApprove

@juwara0
Copy link
Contributor

juwara0 commented Feb 1, 2018 •
edited by cstolli
Loading

👍

Approved with PullApprove

@notmessenger notmessenger merged commit 0840886 into ciena-frost:master Feb 2, 2018
@notmessenger notmessenger deleted the Issue506 branch February 2, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juwara0 juwara0 juwara0 approved these changes

@cstolli cstolli Awaiting requested review from cstolli

@lirwin lirwin Awaiting requested review from lirwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array should provide customizable Add button text, as acronyms are incorrectly translated
2 participants
@notmessenger @juwara0