Consumer offsets #98
Merged
Consumer offsets #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise snappy won't build. Signed-off-by: Tom Most <tmost@blueplanet.com>
Signed-off-by: Tom Most <tmost@blueplanet.com>
Signed-off-by: Tom Most <tmost@blueplanet.com>
This makes them show up once at the same level as methods, rather than twice (once with the ivars and again, undocumented, with the methods). Signed-off-by: Tom Most <tmost@blueplanet.com>
Signed-off-by: Tom Most <tmost@blueplanet.com>
Signed-off-by: Tom Most <tmost@blueplanet.com>
It is bytes, not str. Signed-off-by: Tom Most <tmost@blueplanet.com>
ryban
reviewed
Aug 19, 2019
afkak/test/test_consumer.py
Outdated
| @@ -43,6 +43,9 @@ | |||
| class TestAfkakConsumer(unittest.SynchronousTestCase): | |||
| maxDiff = None | |||
|
|
|||
| def assertNone(self, value): | |||
There was a problem hiding this comment.
It doesn't appear in the SynchronousTestCase API documentation, which is where I looked. It does seem to exist, though. I will switch, thanks!
Signed-off-by: Tom Most <tmost@blueplanet.com>
Signed-off-by: Tom Most <tmost@blueplanet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConsumerGroupdoesn't actually look at the result of stopping its consumers.