Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added passport to person #524

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

eric-bodhi
Copy link
Contributor

No description provided.

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall but I would refactor those tests

src/modules/person/PersonTest.cpp Outdated Show resolved Hide resolved
include/faker-cxx/Person.h Outdated Show resolved Hide resolved
@cieslarmichal cieslarmichal merged commit 8d37101 into cieslarmichal:main Apr 5, 2024
4 checks passed
@eric-bodhi eric-bodhi deleted the passport branch August 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants