refactor: unihan-etl: 0.21.1 -> 0.22.1 (#348)

unihan-etl uses dataclass-based options.
cihai · Jun 19, 2023 · cda4a51 · cda4a51
2 parents f688483 + 6e464a2
commit cda4a51
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/CHANGES b/CHANGES
@@ -4,6 +4,14 @@
 
 <!-- Maintainers, insert changes / features for the next release here -->
 
+_Maintenance only, no bug fixes, or new features_
+
+### Internal improvements
+
+- unihan-etl: 0.21.1 -> 0.22.1 (#348):
+
+  {obj}`dataclasses.dataclass`-based configuration
+
 ## cihai 0.22.1 (2023-06-18)
 
 ### Bug fix

diff --git a/docs/quickstart.md b/docs/quickstart.md
@@ -60,7 +60,7 @@ replaced.
 You may point to a custom config with the `-c` argument, `$ cihai -c path/to/config.yaml`.
 
 You can also override bootstrapping settings. The "unihan_options" dictionary in Cihai's
-configuration will be passed right to {ref}`unihan-etl:index`'s {class}`unihan_etl.process.Packager`
+configuration will be passed right to {ref}`unihan-etl:index`'s {class}`unihan_etl.core.Packager`
 `option` param, which is then merged on top of unihan-etl's default settings:
 
 ```{code-block} yaml

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -57,7 +57,7 @@ python = "^3.8"
 appdirs = "*"
 PyYAML = "~6.0"
 sqlalchemy = {extras = ["mypy"], version = "~2.0"}
-unihan-etl = "~=0.21.1"
+unihan-etl = "~=0.22.1"
 
 [tool.poetry.group.dev.dependencies]
 ### Docs ###

diff --git a/src/cihai/data/unihan/bootstrap.py b/src/cihai/data/unihan/bootstrap.py
@@ -4,7 +4,7 @@
 import sqlalchemy
 from sqlalchemy import Column, String, Table
 
-from unihan_etl import process as unihan
+from unihan_etl import core as unihan
 from unihan_etl.constants import UNIHAN_MANIFEST
 from unihan_etl.util import merge_dict
 
@@ -22,9 +22,9 @@ def bootstrap_unihan(
     """Download, extract and import unihan to database."""
     options = merge_dict(UNIHAN_ETL_DEFAULT_OPTIONS.copy(), options)
 
-    p = unihan.Packager(options)
-    p.download()
-    data = p.export()
+    unihan_pkgr = unihan.Packager(options)
+    unihan_pkgr.download()
+    data = unihan_pkgr.export()
     table = create_unihan_table(UNIHAN_FIELDS, metadata)
 
     metadata.create_all(engine)