Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy v2 support #340

Merged
merged 4 commits into from Jun 3, 2023
Merged

SQLAlchemy v2 support #340

merged 4 commits into from Jun 3, 2023

Conversation

tony
Copy link
Member

@tony tony commented May 6, 2023

@tony tony force-pushed the sqlalchemy2 branch 4 times, most recently from e7c010f to fc2bac9 Compare May 14, 2023 13:11
@tony tony force-pushed the master branch 2 times, most recently from f2ae1b8 to fb78b50 Compare May 27, 2023 13:45
@tony tony force-pushed the sqlalchemy2 branch 2 times, most recently from f096ea0 to 4524e1a Compare June 3, 2023 10:50
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #340 (c7f1519) into master (0ebeb91) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   84.73%   84.77%   +0.04%     
==========================================
  Files          21       21              
  Lines         701      703       +2     
==========================================
+ Hits          594      596       +2     
  Misses        107      107              
Impacted Files Coverage Δ
src/cihai/core.py 84.84% <100.00%> (+0.23%) ⬆️
src/cihai/data/unihan/bootstrap.py 88.88% <100.00%> (+0.51%) ⬆️
src/cihai/data/unihan/dataset.py 92.00% <100.00%> (ø)
src/cihai/db.py 90.90% <100.00%> (-0.40%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the sqlalchemy2 branch 2 times, most recently from 43f4af9 to 9416641 Compare June 3, 2023 17:35
@tony tony merged commit e75c89a into master Jun 3, 2023
9 checks passed
@tony tony deleted the sqlalchemy2 branch June 3, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy v2
1 participant