Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy v2 + mypy strict typings / annotations #311

Merged
merged 6 commits into from
Jun 10, 2023
Merged

SQLAlchemy v2 + mypy strict typings / annotations #311

merged 6 commits into from
Jun 10, 2023

Conversation

@tony tony changed the title build(deps): Bump SQLAlchemy to v2, remove old mypy plugin SQLAlchemy v2 Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #311 (8eaa5ea) into master (3db49b3) will decrease coverage by 21.55%.
The diff coverage is 34.89%.

@@             Coverage Diff             @@
##           master     #311       +/-   ##
===========================================
- Coverage   89.11%   67.57%   -21.55%     
===========================================
  Files           7        7               
  Lines         579      623       +44     
  Branches       79       79               
===========================================
- Hits          516      421       -95     
- Misses         51      197      +146     
+ Partials       12        5        -7     
Impacted Files Coverage Δ
src/unihan_db/importer.py 2.14% <1.80%> (-80.77%) ⬇️
src/unihan_db/bootstrap.py 37.00% <48.38%> (-18.44%) ⬇️
src/unihan_db/tables.py 100.00% <100.00%> (ø)
tests/conftest.py 98.30% <100.00%> (+0.22%) ⬆️
tests/test_bootstrap.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the sqlalchemy2 branch 2 times, most recently from 2c14a84 to 636448f Compare June 4, 2023 16:44
@tony tony force-pushed the sqlalchemy2 branch 2 times, most recently from e11551c to a2b88f7 Compare June 10, 2023 00:15
@tony tony changed the title SQLAlchemy v2 SQLAlchemy v2 + mypy strict typings / annotations Jun 10, 2023
@tony tony merged commit 4a9499b into master Jun 10, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy v2
1 participant