Skip to content

Commit

Permalink
ci(ruff): Remove eradicate / ERA
Browse files Browse the repository at this point in the history
Other ruff rules have been beneficial, eradicate has removed
comments we intended to keep. It requires too much overhead
to be trusted for routine, automated fixups.
  • Loading branch information
tony committed Aug 26, 2023
1 parent f3d2a8c commit 27524b5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ $ pip install --user --upgrade --pre unihan-db

<!-- Maintainers, insert changes / features for the next release here -->

### Development

- ruff: Remove ERA / `eradicate` plugin

This rule had too many false positives to trust. Other ruff rules have been beneficial.

## unihan-db 0.12.0 (2023-07-18)

### Development
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ select = [
"C4", # flake8-comprehensions
"Q", # flake8-quotes
"PTH", # flake8-use-pathlib
"ERA", # eradicate
"SIM", # flake8-simplify
"TRY", # Trycertatops
"PERF", # Perflint
Expand Down

0 comments on commit 27524b5

Please sign in to comment.