Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expansion(kRSGeneric): Fix double apostrophe values with kRSUnicode #304

Merged
merged 3 commits into from
Dec 10, 2023
Merged

expansion(kRSGeneric): Fix double apostrophe values with kRSUnicode #304

merged 3 commits into from
Dec 10, 2023

Commits on Dec 10, 2023

  1. expansion(kRSGeneric): Fix double apostrophe (non-apostrophe, simplif… 

    …ied radical)

via https://www.unicode.org/reports/tr38/#kRSUnicode:

> The standard radical-stroke count for this ideograph in the form “radical.additional strokes.” The radical is indicated by a number in the range 1–214, followed by an optional single apostrophe (U+0027 ' apostrophe) or double apostrophe ('') suffix. A single apostrophe after the radical indicates a Chinese simplified version of the given radical. Two apostrophes after the radical indicates a non-Chinese simplified version of the given radical. The “additional strokes” value is the residual stroke-count, the count of all strokes remaining after eliminating all strokes associated with the radical.
    @tony
    tony committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e9a4691 View commit details
    Browse the repository at this point in the history

  2. docs(CHANGES): Document kRSGeneric fix

    @tony
    tony committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e57bf22 View commit details
    Browse the repository at this point in the history

  3. doctests(expansion): Add test for _expand_kRSGeneric()

    @tony
    tony committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    7a219a4 View commit details
    Browse the repository at this point in the history